You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Deshi Xiao (JIRA)" <ji...@apache.org> on 2017/05/06 01:05:04 UTC
[jira] [Commented] (MESOS-6184) Health checks should use a general
mechanism to enter namespaces of the task.
[ https://issues.apache.org/jira/browse/MESOS-6184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999204#comment-15999204 ]
Deshi Xiao commented on MESOS-6184:
-----------------------------------
it should be rebase and re-submit the patch. [~haosdent@gmail.com]
> Health checks should use a general mechanism to enter namespaces of the task.
> -----------------------------------------------------------------------------
>
> Key: MESOS-6184
> URL: https://issues.apache.org/jira/browse/MESOS-6184
> Project: Mesos
> Issue Type: Improvement
> Reporter: haosdent
> Assignee: haosdent
> Labels: check, health-check, mesosphere
>
> To perform health checks for tasks, we need to enter the corresponding namespaces of the container. For now health check use custom clone to implement this
> {code}
> return process::defaultClone([=]() -> int {
> if (taskPid.isSome()) {
> foreach (const string& ns, namespaces) {
> Try<Nothing> setns = ns::setns(taskPid.get(), ns);
> if (setns.isError()) {
> ...
> }
> }
> }
> return func();
> });
> {code}
> After the childHooks patches merged, we could change the health check to use childHooks to call {{setns}} and make {{process::defaultClone}} private again.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)