You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/11/13 03:03:49 UTC
Review Request 27954: Fix bad review text in review bot.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27954/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
-------
Addressing bad output displayed in https://reviews.apache.org/r/27947/
Diffs
-----
build-support/jenkins/review_feedback.py eaccfa81c323c9f5d284f16d5836e848a05bcb6d
Diff: https://reviews.apache.org/r/27954/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27954: Fix bad review text in review bot.
Posted by Joshua Cohen <jc...@twopensource.com>.
> On Nov. 13, 2014, 4:29 a.m., Kevin Sweeney wrote:
> > build-support/jenkins/review_feedback.py, line 178
> > <https://reviews.apache.org/r/27954/diff/1/?file=760871#file760871line178>
> >
> > prefer interpolation with % review_text
> >
> > over string concatenation
+1
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27954/#review61204
-----------------------------------------------------------
On Nov. 13, 2014, 2:03 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27954/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 2:03 a.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Addressing bad output displayed in https://reviews.apache.org/r/27947/
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py eaccfa81c323c9f5d284f16d5836e848a05bcb6d
>
> Diff: https://reviews.apache.org/r/27954/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27954: Fix bad review text in review bot.
Posted by Bill Farner <wf...@apache.org>.
> On Nov. 13, 2014, 4:29 a.m., Kevin Sweeney wrote:
> > build-support/jenkins/review_feedback.py, line 178
> > <https://reviews.apache.org/r/27954/diff/1/?file=760871#file760871line178>
> >
> > prefer interpolation with % review_text
> >
> > over string concatenation
>
> Joshua Cohen wrote:
> +1
Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27954/#review61204
-----------------------------------------------------------
On Nov. 13, 2014, 2:03 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27954/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 2:03 a.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Addressing bad output displayed in https://reviews.apache.org/r/27947/
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py eaccfa81c323c9f5d284f16d5836e848a05bcb6d
>
> Diff: https://reviews.apache.org/r/27954/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27954: Fix bad review text in review bot.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27954/#review61204
-----------------------------------------------------------
Ship it!
build-support/jenkins/review_feedback.py
<https://reviews.apache.org/r/27954/#comment102726>
prefer interpolation with % review_text
over string concatenation
- Kevin Sweeney
On Nov. 12, 2014, 6:03 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27954/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 6:03 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Addressing bad output displayed in https://reviews.apache.org/r/27947/
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py eaccfa81c323c9f5d284f16d5836e848a05bcb6d
>
> Diff: https://reviews.apache.org/r/27954/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27954: Fix bad review text in review bot.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27954/#review61182
-----------------------------------------------------------
Ship it!
Master (6950d50) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 13, 2014, 2:03 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27954/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 2:03 a.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Addressing bad output displayed in https://reviews.apache.org/r/27947/
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py eaccfa81c323c9f5d284f16d5836e848a05bcb6d
>
> Diff: https://reviews.apache.org/r/27954/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27954: Fix bad review text in review bot.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27954/
-----------------------------------------------------------
(Updated Nov. 13, 2014, 6:05 p.m.)
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
Addressing bad output displayed in https://reviews.apache.org/r/27947/
Diffs (updated)
-----
build-support/jenkins/review_feedback.py eaccfa81c323c9f5d284f16d5836e848a05bcb6d
Diff: https://reviews.apache.org/r/27954/diff/
Testing
-------
Thanks,
Bill Farner