You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/02 17:30:20 UTC

[GitHub] [airflow] xinbinhuang commented on a change in pull request #14554: Remove unnecessary WARNINGs from BeamHook

xinbinhuang commented on a change in pull request #14554:
URL: https://github.com/apache/airflow/pull/14554#discussion_r585766093



##########
File path: airflow/providers/apache/beam/hooks/beam.py
##########
@@ -25,7 +25,7 @@
 from typing import Callable, List, Optional
 
 from airflow.exceptions import AirflowException
-from airflow.hooks.base_hook import BaseHook
+from airflow.hooks.base import BaseHook

Review comment:
       Thanks for pointing this out. I am actually not sure how it will behave in the backport-providers, but I think it will work because other provider packages are also using the new import paths, i.e. Google Cloud Provider https://github.com/apache/airflow/blob/3064bf04429f86ff2b527704603ef3ca9b9fe22f/airflow/providers/google/common/hooks/base_google.py#L44
   
   My guess is that we have a script that rewrites all the import paths when releasing the backport packages. @potiuk do you mind shedding some light on this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org