[GitHub] [helix] qqu0127 commented on a diff in pull request #2201: Downgraded Deletion Error Logs to Avoid Error Spam Logging

[GitBox <gi...@apache.org>]

qqu0127 commented on code in PR #2201:
URL: https://github.com/apache/helix/pull/2201#discussion_r963972631


##########
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java:
##########
@@ -726,7 +726,7 @@ public boolean remove(String path, int options) {
       // case, we try to delete recursively
       _zkClient.delete(path);
     } catch (ZkException e) {
-      LOG.debug("Failed to delete {} with opts {}, err: {}. Try recursive delete", path, options,
+      LOG.info("Failed to delete {} with opts {}, err: {}. Try recursive delete", path, options,

Review Comment:
   Just FYI, change from debug to info is a up-level. We may see more logs like this, is this what we want? (most default log level is at INFO or plus)



##########
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java:
##########
@@ -433,6 +433,36 @@ public void testSyncRemove() {
     System.out.println("END " + testName + " at " + new Date(System.currentTimeMillis()));
   }
 
+  @Test
+  public void testDeleteLogging() {
+    String root = _rootPath;
+
+    ZkBaseDataAccessor<ZNRecord> accessor = new ZkBaseDataAccessor<>(_gZkClient);

Review Comment:
   Thanks for writing up the test. 
   Logging test can be tricky, it depends on the configuration of log level in test environment, and there isn't a good way to verify the log message. 
   If I understand correctly, this test is only to test logging, but not to test the delete functionality?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org