You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/21 03:22:17 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6648: Added Adafruit QT Py RP2040 board and made UART, SPI, and I2C configuration more flexible.

xiaoxiang781216 commented on code in PR #6648:
URL: https://github.com/apache/incubator-nuttx/pull/6648#discussion_r926217634


##########
arch/arm/src/rp2040/Kconfig:
##########
@@ -13,9 +20,63 @@ config RP2040_UART0
 
 if RP2040_UART0
 
+config RP2040_UART0_TX_GPIO

Review Comment:
   RP2040_UART0_TX_GPIO is only used in the board file, how about we create a top level Kconfig at:
   boards/arm/rp2040/Kconfig or
   boards/arm/rp2040/common/Kconfig
   to define this common option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org