You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/29 09:54:10 UTC
[GitHub] [lucene-solr] iverase opened a new pull request #2269: LUCENE-9322: Add TestLucene90FieldInfosFormat
iverase opened a new pull request #2269:
URL: https://github.com/apache/lucene-solr/pull/2269
When introducing the new Vector format, we introduced as well a new FieldInfos format. This PR add the test for this format, similar to what it was done for the previous one.
@msokolov I think we should introduce one of this test for the Vector format (test that extends `BaseIndexFileFormatTestCase`). wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] iverase merged pull request #2269: LUCENE-9322: Add TestLucene90FieldInfosFormat
Posted by GitBox <gi...@apache.org>.
iverase merged pull request #2269:
URL: https://github.com/apache/lucene-solr/pull/2269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] msokolov commented on pull request #2269: LUCENE-9322: Add TestLucene90FieldInfosFormat
Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #2269:
URL: https://github.com/apache/lucene-solr/pull/2269#issuecomment-776697104
Sorry, just catching up on my emails now -- I agree @iverase , we should expand test coverage for these formats to the level we have for the others. Thanks for opening the issue @jtibshirani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani commented on pull request #2269: LUCENE-9322: Add TestLucene90FieldInfosFormat
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #2269:
URL: https://github.com/apache/lucene-solr/pull/2269#issuecomment-776361691
I opened https://issues.apache.org/jira/browse/LUCENE-9756 to add tests for points and vectors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org