[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3029: ARTEMIS-2664 Fix the delivered acks decrement.

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3029: ARTEMIS-2664 Fix the delivered acks decrement.
URL: https://github.com/apache/activemq-artemis/pull/3029#discussion_r394513209
 
 

 ##########
 File path: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java
 ##########
 @@ -306,15 +306,12 @@ public void acknowledge(MessageAck ack) throws Exception {
       List<MessageReference> ackList = serverConsumer.getDeliveringReferencesBasedOnProtocol(removeReferences, first, last);
 
       if (removeReferences && (ack.isIndividualAck() || ack.isStandardAck() || ack.isPoisonAck())) {
-         this.deliveredAcks.getAndUpdate(deliveredAcks -> {
-            if (deliveredAcks >= ackList.size()) {
-               return deliveredAcks - ackList.size();
-            }
-
-            acquireCredit(ackList.size() - deliveredAcks);
+         int previousDeliveredAcks = this.deliveredAcks.getAndUpdate(
+            deliveredAcks -> deliveredAcks > ackList.size() ? deliveredAcks - ackList.size() : 0);
 
 Review comment:
   I guess the commit message is not clear enough.. I think the problem is the nubmer of times acquiredCredits is called?
   
   I would be a bit more descriptive on the commit message if this is the issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services