[GitHub] [doris] liaoxin01 commented on a diff in pull request #20883: [Fix](core) Get tablet version should hold meta lock

["liaoxin01 (via GitHub)" <gi...@apache.org>]

liaoxin01 commented on code in PR #20883:
URL: https://github.com/apache/doris/pull/20883#discussion_r1231733652


##########
be/src/olap/tablet.h:
##########
@@ -449,7 +449,7 @@ class Tablet : public BaseTablet {
 
     Status commit_phase_update_delete_bitmap(
             const RowsetSharedPtr& rowset, const RowsetIdUnorderedSet& pre_rowset_ids,
-            DeleteBitmapPtr delete_bitmap, const int64_t& cur_version,
+            DeleteBitmapPtr delete_bitmap, const TabletSharedPtr tablet,

Review Comment:
   No need to pass `tablet` parameter.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org