You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Carlos Sanchez (JIRA)" <ji...@apache.org> on 2007/04/11 07:51:32 UTC

[jira] Created: (FELIX-269) Don't run the plugin on pom projects

Don't run the plugin on pom projects
------------------------------------

                 Key: FELIX-269
                 URL: https://issues.apache.org/jira/browse/FELIX-269
             Project: Felix
          Issue Type: Bug
          Components: Maven Bundle Plugin
    Affects Versions: 1.0.0
            Reporter: Carlos Sanchez


useful when configuring it on the parent pom

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Created: (FELIX-269) Don't run the plugin on pom projects

Posted by Carlos Sanchez <ca...@apache.org>.
I don't think they are related. This patch solves a problem when you
configure the plugin in your parent pom and then all kinds of projects
inherit and try to execute it, failing of course for pom projects (no
jar, no classes,...).

On 4/10/07, Niclas Hedhman <ni...@hedhman.org> wrote:
> On Wednesday 11 April 2007 13:51, Carlos Sanchez (JIRA) wrote:
>
> Is this related to the 'odd' behavior of Maven when it comes to the resolution
> of 'type' vs 'extension'??
>
> For instance; when running "mvn install" from [1] the modules, such as api
> will get a ".jar" generated, but if run from [2] then a ".bundle" will be
> generated. It is probably the same case as [3], but not sure.
>
>
> [1] https://scm.ops4h.org/repos/ops4j/projects/pax/logging
> [2] https://scm.ops4h.org/repos/ops4j/projects/pax
> [3] http://jira.codehaus.org/browse/MNG-1682
>
> Cheers
> Niclas Hedhman, Software Developer
> --
> I  live here; http://tinyurl.com/2qq9er
> I  work here; http://tinyurl.com/2ymelc
> I relax here; http://tinyurl.com/2cgsug
>


-- 
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
                             -- The Princess Bride

Re: [jira] Created: (FELIX-269) Don't run the plugin on pom projects

Posted by Niclas Hedhman <ni...@hedhman.org>.
On Wednesday 11 April 2007 13:51, Carlos Sanchez (JIRA) wrote:

Is this related to the 'odd' behavior of Maven when it comes to the resolution 
of 'type' vs 'extension'??

For instance; when running "mvn install" from [1] the modules, such as api 
will get a ".jar" generated, but if run from [2] then a ".bundle" will be 
generated. It is probably the same case as [3], but not sure.


[1] https://scm.ops4h.org/repos/ops4j/projects/pax/logging
[2] https://scm.ops4h.org/repos/ops4j/projects/pax
[3] http://jira.codehaus.org/browse/MNG-1682

Cheers 
Niclas Hedhman, Software Developer
--
I  live here; http://tinyurl.com/2qq9er
I  work here; http://tinyurl.com/2ymelc
I relax here; http://tinyurl.com/2cgsug

[jira] Commented: (FELIX-269) Don't run the plugin on pom projects

Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487998 ] 

Carlos Sanchez commented on FELIX-269:
--------------------------------------

BTW this is what I use in the parent pom to make the generated jar have OSGi info

      <plugin>
        <groupId>org.apache.felix</groupId>
        <artifactId>maven-bundle-plugin</artifactId>
        <version>0.9.0-incubator-SNAPSHOT</version>
        <executions>
          <execution>
            <goals>
              <goal>manifest</goal>
            </goals>
          </execution>
        </executions>
      </plugin>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-jar-plugin</artifactId>
        <configuration>
          <archive>
            <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
          </archive>
        </configuration>
      </plugin>


> Don't run the plugin on pom projects
> ------------------------------------
>
>                 Key: FELIX-269
>                 URL: https://issues.apache.org/jira/browse/FELIX-269
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: 1.0.0
>            Reporter: Carlos Sanchez
>         Attachments: FELIX-269.patch
>
>
> useful when configuring it on the parent pom

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-269) Don't run the plugin on pom projects

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall resolved FELIX-269.
-----------------------------------

    Resolution: Fixed
      Assignee: Richard S. Hall

Applied patch. Carlos, please close this issue if you are happy with it.

> Don't run the plugin on pom projects
> ------------------------------------
>
>                 Key: FELIX-269
>                 URL: https://issues.apache.org/jira/browse/FELIX-269
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: 1.0.0
>            Reporter: Carlos Sanchez
>         Assigned To: Richard S. Hall
>         Attachments: example-bundle-pom-layout.zip, FELIX-269.patch
>
>
> useful when configuring it on the parent pom

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-269) Don't run the plugin on pom projects

Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stuart McCulloch updated FELIX-269:
-----------------------------------

    Attachment: example-bundle-pom-layout.zip

Just for reference, attached is a sample pom layout produced by Pax Construct ( http://wiki.ops4j.org/confluence/display/ops4j/Pax+Construct ) that uses the pluginManagement/plugin style.

It's just an example - but you can do a "mvn clean install pax:provision" and the bundles will deploy onto Equinox.

> Don't run the plugin on pom projects
> ------------------------------------
>
>                 Key: FELIX-269
>                 URL: https://issues.apache.org/jira/browse/FELIX-269
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: 1.0.0
>            Reporter: Carlos Sanchez
>         Attachments: example-bundle-pom-layout.zip, FELIX-269.patch
>
>
> useful when configuring it on the parent pom

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FELIX-269) Don't run the plugin on pom projects

Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carlos Sanchez closed FELIX-269.
--------------------------------


> Don't run the plugin on pom projects
> ------------------------------------
>
>                 Key: FELIX-269
>                 URL: https://issues.apache.org/jira/browse/FELIX-269
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: 1.0.0
>            Reporter: Carlos Sanchez
>         Assigned To: Richard S. Hall
>         Attachments: example-bundle-pom-layout.zip, FELIX-269.patch
>
>
> useful when configuring it on the parent pom

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-269) Don't run the plugin on pom projects

Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487997 ] 

Stuart McCulloch commented on FELIX-269:
----------------------------------------

My 2 cents ... these days I configure the bundle plugin in the pluginManagement section of the parent pom - that way I only need to add a small fragment of xml to the plugin section of the child poms, and so far I haven't suffered from the extension bug (touch wood!). But a lot of people do use the plugin section of the parent pom, so this would be useful.

> Don't run the plugin on pom projects
> ------------------------------------
>
>                 Key: FELIX-269
>                 URL: https://issues.apache.org/jira/browse/FELIX-269
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: 1.0.0
>            Reporter: Carlos Sanchez
>         Attachments: FELIX-269.patch
>
>
> useful when configuring it on the parent pom

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-269) Don't run the plugin on pom projects

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492497 ] 

Richard S. Hall commented on FELIX-269:
---------------------------------------

There was a bug in this patch, which was causing the build to fail...it was using type "osgi-bundle" instead of "bundle" to test for supported project types.

> Don't run the plugin on pom projects
> ------------------------------------
>
>                 Key: FELIX-269
>                 URL: https://issues.apache.org/jira/browse/FELIX-269
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: 1.0.0
>            Reporter: Carlos Sanchez
>         Assigned To: Richard S. Hall
>         Attachments: example-bundle-pom-layout.zip, FELIX-269.patch
>
>
> useful when configuring it on the parent pom

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-269) Don't run the plugin on pom projects

Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carlos Sanchez updated FELIX-269:
---------------------------------

    Attachment: FELIX-269.patch

> Don't run the plugin on pom projects
> ------------------------------------
>
>                 Key: FELIX-269
>                 URL: https://issues.apache.org/jira/browse/FELIX-269
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: 1.0.0
>            Reporter: Carlos Sanchez
>         Attachments: FELIX-269.patch
>
>
> useful when configuring it on the parent pom

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.