You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucy.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/05 18:28:40 UTC
[lucy-issues] [jira] [Commented] (CLOWNFISH-14) Test CFC exceptions in C
[ https://issues.apache.org/jira/browse/CLOWNFISH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181783#comment-15181783 ]
ASF GitHub Bot commented on CLOWNFISH-14:
-----------------------------------------
GitHub user nwellnhof opened a pull request:
https://github.com/apache/lucy-clownfish/pull/61
Test CFC exceptions in the C test suite
Add support to catch CFC exceptions from C and start testing exceptions in the C test suite of the compiler.
Fixes CLOWNFISH-14.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nwellnhof/lucy-clownfish catch-cfc-exceptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/61.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #61
----
commit 65387c4fe5f0088fe89c90a9d0a1e8829fabb0f3
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2016-03-04T16:54:20Z
Implement CFCUtil_vsprintf
Drop support for Microsoft compilers without _vscprintf. This function
is supported at least since Visual Studio .NET 2003 (MSVC 7.1). I think
it was only MSVC 6 that didn't support it.
Also use va_copy when iterating va_lists twice.
commit 5d0a3efefc68ae1ea81564a0184d70273db75623
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2016-03-04T16:58:28Z
Support catching CFC exceptions from C
Needed to fix CLOWNFISH-14.
commit ce0dfbb5a77b55ca59f97eb9cdd6a5de7f59ad86
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2016-03-05T16:50:13Z
Fix a couple of leaking exceptions
commit 6fdf098cef2a360218df6fc666e52d9af5b87152
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2016-03-05T17:09:27Z
Finish support for skipping CFC tests
commit e3ecf10da6a3314c31e60133041ed3578357387b
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2016-03-04T17:00:49Z
Test CFC exceptions in C test suite
Catching exceptions sometimes requires a separate function because
stack variables might be clobbered by longjmp. See
http://stackoverflow.com/q/2024933
Also add some other parcel tests from the Perl test suite.
Fixes CLOWNFISH-14.
commit df605b501d441251871450f9f46ab11b601781f4
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2016-03-05T17:17:00Z
Remove Perl test t/502-clash.t
This test is part of C test suite now.
----
> Test CFC exceptions in C
> ------------------------
>
> Key: CLOWNFISH-14
> URL: https://issues.apache.org/jira/browse/CLOWNFISH-14
> Project: Apache Lucy-Clownfish
> Issue Type: Improvement
> Components: Compiler, Tests
> Reporter: Nick Wellnhofer
> Assignee: Nick Wellnhofer
> Priority: Minor
> Fix For: 0.6.0
>
>
> Code paths that throw exceptions via CFCUtil_die() can't be tested yet from C because we need a mechanism to catch those exceptions. This has already been implemented for Lucy (or the Clownfish runtime) as part of Clownfish::Err. It shouldn't be too hard to port this code to CFC. Then the remaining tests from the Perl test suite can be ported to C.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)