You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/01 09:04:32 UTC

[GitHub] [spark] yaooqinn commented on pull request #28674: [SPARK-31868][SQL] Restore the parsing behaviour week-based-year for 2.4

yaooqinn commented on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636718215


   > Can we define the 2.4 behavior first? The behavior looks very weird to me. 
   
   I found it very difficult to follow the behavior of 2.4. It is also hard to fully define it.
   
   > If it doesn't make sense, we can narrow down the scope or even forbid it.
   
   I agree that we can narrow down the scope of our new formatter
   
   First of all, I suggest that we fail the 'Y' field to work with other non-week-based date fields y/M/L/d, etc as they are silently omitted.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org