You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by GitBox <gi...@apache.org> on 2019/05/15 13:49:48 UTC
[GitHub] [lucene-solr] dsmiley commented on issue #665: Fixes SOLR-11841,
SOLR-13331, SOLR-13347
dsmiley commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-492662755
It'd help to review your changes if you made fewer arbitrary changes, like adding 'final' and changing indentation of javadocs that were fine as they were.
Also, it'd help to summarize why 3 different issues are being fixed in one PR. Might be just fine but please add info/context to make reviewer's job either or you may not get a review at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org