You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2011/02/19 18:52:38 UTC

[jira] Created: (DERBY-5062) [patch] push code assignments down to where they are used - part 2

[patch] push code assignments down to where they are used - part 2
------------------------------------------------------------------

                 Key: DERBY-5062
                 URL: https://issues.apache.org/jira/browse/DERBY-5062
             Project: Derby
          Issue Type: Improvement
          Components: Services
    Affects Versions: 10.7.1.1
            Reporter: Dave Brosius
            Priority: Trivial
             Fix For: 10.8.0.0
         Attachments: push_down_code.diff

code does various assignments at a higher level than the assignments are needed, causing code to execute unnecessarily if the expected code path isn't taken. Push these assignments down to where they are actually used.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-5062) [patch] push code assignments down to where they are used - part 2

Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998693#comment-12998693 ] 

Lily Wei commented on DERBY-5062:
---------------------------------

Suites.all and derbyall run clean with this patch. If there is no objection, I will commit this patch soon.

> [patch] push code assignments down to where they are used - part 2
> ------------------------------------------------------------------
>
>                 Key: DERBY-5062
>                 URL: https://issues.apache.org/jira/browse/DERBY-5062
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 10.8.0.0
>
>         Attachments: push_down_code.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> code does various assignments at a higher level than the assignments are needed, causing code to execute unnecessarily if the expected code path isn't taken. Push these assignments down to where they are actually used.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (DERBY-5062) [patch] push code assignments down to where they are used - part 2

Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius closed DERBY-5062.
-------------------------------


> [patch] push code assignments down to where they are used - part 2
> ------------------------------------------------------------------
>
>                 Key: DERBY-5062
>                 URL: https://issues.apache.org/jira/browse/DERBY-5062
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>              Labels: derby_triage10_8
>             Fix For: 10.8.0.0
>
>         Attachments: push_down_code.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> code does various assignments at a higher level than the assignments are needed, causing code to execute unnecessarily if the expected code path isn't taken. Push these assignments down to where they are actually used.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DERBY-5062) [patch] push code assignments down to where they are used - part 2

Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lily Wei updated DERBY-5062:
----------------------------

      Issue & fix info: [Patch Available]
              Assignee: Dave Brosius
    Bug behavior facts: [Performance]
                Labels: derby_triage10_8  (was: )

I've committed with revision 1074227.Thanks, Dave.

> [patch] push code assignments down to where they are used - part 2
> ------------------------------------------------------------------
>
>                 Key: DERBY-5062
>                 URL: https://issues.apache.org/jira/browse/DERBY-5062
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>              Labels: derby_triage10_8
>             Fix For: 10.8.0.0
>
>         Attachments: push_down_code.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> code does various assignments at a higher level than the assignments are needed, causing code to execute unnecessarily if the expected code path isn't taken. Push these assignments down to where they are actually used.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (DERBY-5062) [patch] push code assignments down to where they are used - part 2

Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius resolved DERBY-5062.
---------------------------------

    Resolution: Fixed

> [patch] push code assignments down to where they are used - part 2
> ------------------------------------------------------------------
>
>                 Key: DERBY-5062
>                 URL: https://issues.apache.org/jira/browse/DERBY-5062
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>              Labels: derby_triage10_8
>             Fix For: 10.8.0.0
>
>         Attachments: push_down_code.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> code does various assignments at a higher level than the assignments are needed, causing code to execute unnecessarily if the expected code path isn't taken. Push these assignments down to where they are actually used.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira