You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2024/05/08 18:01:04 UTC

Re: [PR] feat(dashboard): Add metadata bar to the header [superset]

codecov-commenter commented on PR #27857:
URL: https://github.com/apache/superset/pull/27857#issuecomment-2101118117

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27857?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `57.14286%` with `3 lines` in your changes are missing coverage. Please review.
   > Project coverage is 64.09%. Comparing base [(`2e5f3ed`)](https://app.codecov.io/gh/apache/superset/commit/2e5f3ed85149951200645e00e79a543de9bec02f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8dd320c`)](https://app.codecov.io/gh/apache/superset/pull/27857?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 51 commits behind head on master.
   
   | [Files](https://app.codecov.io/gh/apache/superset/pull/27857?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/models/dashboard.py](https://app.codecov.io/gh/apache/superset/pull/27857?src=pr&el=tree&filepath=superset%2Fmodels%2Fdashboard.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/27857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #27857      +/-   ##
   ==========================================
   + Coverage   60.49%   64.09%   +3.60%     
   ==========================================
     Files        1931      521    -1410     
     Lines       76241    37220   -39021     
     Branches     8566        0    -8566     
   ==========================================
   - Hits        46122    23858   -22264     
   + Misses      28015    13362   -14653     
   + Partials     2104        0    -2104     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/27857/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/27857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.09% <57.14%> (-0.08%)` | :arrow_down: |
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/27857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/27857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.68% <57.14%> (-0.13%)` | :arrow_down: |
   | [python](https://app.codecov.io/gh/apache/superset/pull/27857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.09% <57.14%> (+0.61%)` | :arrow_up: |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/27857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.31% <57.14%> (+0.68%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/27857?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org