You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/24 13:58:02 UTC

[GitHub] [arrow-datafusion] waynexia commented on a diff in pull request #2602: Remove `ExecutionProps` from `OptimizerRule` trait

waynexia commented on code in PR #2602:
URL: https://github.com/apache/arrow-datafusion/pull/2602#discussion_r880547964


##########
datafusion/core/src/execution/context.rs:
##########
@@ -1130,7 +1130,7 @@ impl SessionConfig {
 /// done so during predicate pruning and expression simplification
 #[derive(Clone)]
 pub struct ExecutionProps {
-    pub(crate) query_execution_start_time: DateTime<Utc>,
+    pub(crate) query_execution_start_time: Arc<Mutex<DateTime<Utc>>>,

Review Comment:
   I think this mutex is not needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org