[jira] [Commented] (FLINK-8979) Extend Kafka end-to-end tests to run with different versions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416907#comment-16416907 ] 

ASF GitHub Bot commented on FLINK-8979:
---------------------------------------

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/5778

    [FLINK-8979] (part 1) Make Kafka end-to-end tests not embarrassingly parallel

    ## What is the purpose of the change
    
    This PR improves the behaviour test coverage of Kafka end-to-end tests by introducing a shuffle in the tested pipeline.
    
    ## Brief change log
    
    - Refactor common Kafka-related scripts to `kafka-common.sh`
    - Adapt the `Kafka010Example` to include a shuffle. The DOP and test data of `test_streaming_kafka010.sh` has also been modified.
    
    ## Verifying this change
    
    This PR is purely a change to our current tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-8979

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5778
    
----
commit 7043de0257399b99f75dd8df7c8f009b5d51ce99
Author: Tzu-Li (Gordon) Tai <tz...@...>
Date:   2018-03-27T10:06:19Z

    [FLINK-8979] [test] Refactor Kafka-related common end-to-end test scripts

commit 4b1fd5d7cb5596565c1d5dca867d80433aad5bc6
Author: Tzu-Li (Gordon) Tai <tz...@...>
Date:   2018-03-27T13:14:35Z

    [FLINK-8979] [test] Include shuffles in Kafka end-to-end tests

----


> Extend Kafka end-to-end tests to run with different versions
> ------------------------------------------------------------
>
>                 Key: FLINK-8979
>                 URL: https://issues.apache.org/jira/browse/FLINK-8979
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> The current {{Kafka}} end-to-end test only runs with Kafka 0.10. We should extend the test to also run with
> * Kafka 0.8
> * Kafka 0.9
> * Kafka 0.11
> Additionally we should change the test job to not be embarrassingly parallel by introducing a shuffle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)