You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/26 07:01:33 UTC
[GitHub] [flink] tsreaper opened a new pull request #16591: [FLINK-19739][table-runtime] Fix compile exception for window aggregate in batch jobs
tsreaper opened a new pull request #16591:
URL: https://github.com/apache/flink/pull/16591
## What is the purpose of the change
Currently generated code for window aggregate in batch jobs will not compile if the aggregation has no grouping keys or any named properties (such as tumble_start). This PR fixes this issue.
## Brief change log
- Fix compile exception for window aggregate in batch jobs
## Verifying this change
This change added tests and can be verified by running the added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16591: [FLINK-19739][table-runtime] Fix compile exception for window aggregate in batch jobs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16591:
URL: https://github.com/apache/flink/pull/16591#issuecomment-886445662
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20949",
"triggerID" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"triggerType" : "PUSH"
}, {
"hash" : "1479fde3564b86298ac71c43f94e08bfa9a8f40a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21019",
"triggerID" : "1479fde3564b86298ac71c43f94e08bfa9a8f40a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1479fde3564b86298ac71c43f94e08bfa9a8f40a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21019)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16591: [FLINK-19739][table-runtime] Fix compile exception for window aggregate in batch jobs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16591:
URL: https://github.com/apache/flink/pull/16591#issuecomment-886445662
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88078df2f1cf8f061ea89555c667c7d386f83a89 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16591: [FLINK-19739][table-runtime] Fix compile exception for window aggregate in batch jobs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16591:
URL: https://github.com/apache/flink/pull/16591#issuecomment-886434802
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 88078df2f1cf8f061ea89555c667c7d386f83a89 (Mon Jul 26 07:05:34 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19739).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16591: [FLINK-19739][table-runtime] Fix compile exception for window aggregate in batch jobs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16591:
URL: https://github.com/apache/flink/pull/16591#issuecomment-886445662
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20949",
"triggerID" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"triggerType" : "PUSH"
}, {
"hash" : "1479fde3564b86298ac71c43f94e08bfa9a8f40a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21019",
"triggerID" : "1479fde3564b86298ac71c43f94e08bfa9a8f40a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88078df2f1cf8f061ea89555c667c7d386f83a89 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20949)
* 1479fde3564b86298ac71c43f94e08bfa9a8f40a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21019)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16591: [FLINK-19739][table-runtime] Fix compile exception for window aggregate in batch jobs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16591:
URL: https://github.com/apache/flink/pull/16591#issuecomment-886445662
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20949",
"triggerID" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88078df2f1cf8f061ea89555c667c7d386f83a89 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20949)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #16591: [FLINK-19739][table-runtime] Fix compile exception for window aggregate in batch jobs
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #16591:
URL: https://github.com/apache/flink/pull/16591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16591: [FLINK-19739][table-runtime] Fix compile exception for window aggregate in batch jobs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16591:
URL: https://github.com/apache/flink/pull/16591#issuecomment-886445662
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20949",
"triggerID" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"triggerType" : "PUSH"
}, {
"hash" : "1479fde3564b86298ac71c43f94e08bfa9a8f40a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1479fde3564b86298ac71c43f94e08bfa9a8f40a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88078df2f1cf8f061ea89555c667c7d386f83a89 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20949)
* 1479fde3564b86298ac71c43f94e08bfa9a8f40a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #16591: [FLINK-19739][table-runtime] Fix compile exception for window aggregate in batch jobs
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #16591:
URL: https://github.com/apache/flink/pull/16591#discussion_r677176697
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/agg/WindowAggregateITCase.scala
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.runtime.batch.sql.agg
+
+import java.time.LocalDateTime
+
+import org.apache.flink.table.planner.factories.TestValuesTableFactory
+import org.apache.flink.table.planner.runtime.utils.BatchTestBase
+import org.apache.flink.table.planner.runtime.utils.BatchTestBase.row
+import org.apache.flink.types.Row
+import org.junit.Test
+
+class WindowAggregateITCase extends BatchTestBase {
+
+ @Test
+ def testLocalGlobalWindowAggregateWithoutGroupingAndNamedProperties(): Unit = {
Review comment:
Put this case into `GroupWindowITCase`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16591: [FLINK-19739][table-runtime] Fix compile exception for window aggregate in batch jobs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16591:
URL: https://github.com/apache/flink/pull/16591#issuecomment-886445662
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20949",
"triggerID" : "88078df2f1cf8f061ea89555c667c7d386f83a89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88078df2f1cf8f061ea89555c667c7d386f83a89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20949)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16591: [FLINK-19739][table-runtime] Fix compile exception for window aggregate in batch jobs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16591:
URL: https://github.com/apache/flink/pull/16591#issuecomment-886434802
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1479fde3564b86298ac71c43f94e08bfa9a8f40a (Sat Aug 28 12:23:21 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org