You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2026/01/21 01:01:33 UTC
[PR] [SPARK-54371][SPARK-39959][INFRA][3.5] Pin roxygen2 and pkgdown versions for SparkR doc generation [spark]
cloud-fan opened a new pull request, #53878:
URL: https://github.com/apache/spark/pull/53878
### What changes were proposed in this pull request?
This PR backports R package version pinning from master to branch-3.5:
1. Pin `roxygen2` to version 7.2.0 (per SPARK-39959)
2. Pin `lintr` to version 2.0.1 instead of installing from GitHub
3. Install `pkgdown` at the end to prevent version upgrade (per SPARK-54371)
### Why are the changes needed?
The SparkR documentation generated for v3.5.8 differs significantly from v4.2.0-preview1 despite no major API changes. Investigation revealed:
1. **roxygen2 version issue**: The branch-3.5 Dockerfile uses `install.packages('roxygen2')` which installs the latest version from CRAN (7.3.x+), while master pins it to 7.2.0. Different roxygen2 versions generate `.Rd` files differently, affecting the final HTML output.
2. **pkgdown version upgrade**: When `preferably` is installed after `pkgdown`, it can upgrade pkgdown from 2.0.1 to 2.2.0 due to dependency resolution. Installing pkgdown LAST prevents this.
See:
- https://dist.apache.org/repos/dist/release/spark/docs/3.5.8/api/R/reference/
- https://dist.apache.org/repos/dist/release/spark/docs/4.2.0-preview1/api/R/reference/
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
This is a backport of fixes already validated on master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54371][SPARK-39959][INFRA][3.5] Pin roxygen2 and pkgdown versions for SparkR doc generation [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #53878: [SPARK-54371][SPARK-39959][INFRA][3.5] Pin roxygen2 and pkgdown versions for SparkR doc generation
URL: https://github.com/apache/spark/pull/53878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54371][SPARK-39959][INFRA][3.5] Pin roxygen2 and pkgdown versions for SparkR doc generation [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #53878:
URL: https://github.com/apache/spark/pull/53878#issuecomment-3775984597
thanks for the review, merging to 3.5!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54371][SPARK-39959][INFRA][3.5] Pin roxygen2 and pkgdown versions for SparkR doc generation [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #53878:
URL: https://github.com/apache/spark/pull/53878#issuecomment-3775651772
cc @holdenk , @huaxingao , @mridulm since they want to maintain `branch-3.5`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54371][SPARK-39959][INFRA][3.5] Pin roxygen2 and pkgdown versions for SparkR doc generation [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53878:
URL: https://github.com/apache/spark/pull/53878#issuecomment-3775641809
## JIRA Issue Information
=== Sub-task SPARK-54371 ===
Summary: Fix `spark-rm` Dockefile to install `pkgdown` version at the end
Assignee: Dongjoon Hyun
Status: Resolved
Affected: ["4.1.0"]
=== Test SPARK-39959 ===
Summary: Recover SparkR CRAN check in GitHub Actions CI
Assignee: Yikun Jiang
Status: Resolved
Affected: ["3.4.0"]
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54371][SPARK-39959][INFRA][3.5] Pin roxygen2 and pkgdown versions for SparkR doc generation [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #53878:
URL: https://github.com/apache/spark/pull/53878#issuecomment-3775646758
cc @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org