You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Uwe Schindler (Jira)" <ji...@apache.org> on 2019/11/16 17:28:00 UTC

[jira] [Commented] (SOLR-13938) Make buildSrc not so trappy for the Gradle build

    [ https://issues.apache.org/jira/browse/SOLR-13938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975758#comment-16975758 ] 

Uwe Schindler commented on SOLR-13938:
--------------------------------------

We shod not change this. The same problem applies if we change the versions of dependencies. The correct way to solve this: remove the ant and maven build. Period.

Uwe

> Make buildSrc not so trappy for the Gradle build
> ------------------------------------------------
>
>                 Key: SOLR-13938
>                 URL: https://issues.apache.org/jira/browse/SOLR-13938
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>         Environment: Just spent a couple of hours trying to figure out why my latest attempt to merge master into the gradle build failed with a precommit warning about 
> {code}
> Forbidden method invocation: java.lang.Math#toRadians(double) [Use home-grown methods instead]
>   in org.apache.lucene.geo.Rectangle (Rectangle.java:155)
> {code}
> It turns out that we keep copies of "shared"(?) resources in buildSrc, specifically in this case there are now two copies of some files in Git, in this case:
> ./lucene/tools/forbiddenApis/lucene.txt
> ./buildSrc/src/main/resources/forbidden/lucene.txt
> This one was recently changed to remove a couple of entries on master:
> ./lucene/tools/forbiddenApis/lucene.txt
> But this one is unchanged:
> ./buildSrc/src/main/resources/forbidden/lucene.txt
> I can find no targets that update this automagically.
>            Reporter: Erick Erickson
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org