You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/07/26 15:32:23 UTC
[GitHub] [cordova-android] breautek opened a new pull request #1293: fix: gradle build tools config
breautek opened a new pull request #1293:
URL: https://github.com/apache/cordova-android/pull/1293
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Fixes a regression outlined in https://github.com/apache/cordova-android/issues/1290
Closes https://github.com/apache/cordova-android/issues/1290
While cordova-android always used the latest build tools version by default, through gradle parameters users could pin their build tools version to a specific version. In 10.x this behaviour was changed so that the gradle parameter value was used as hte minimum version instead of the desired build tools version.
### Description
<!-- Describe your changes in detail -->
I added a `MIN_BUILD_TOOLS_VERSION` as our declared minimum build tools version. The previously declared `BUILD_TOOLS_VERSION` now is unset by default, but will become either the latest build tools version that is available or the declared build tools version configured by `config.xml` preference or the gradle args CLI parameter.
Additionally I marked the `doFindLatestInstalledBuildTools` as deprecated, because we shouldn't be blindly choosing the latest version available. https://github.com/apache/cordova-android/issues/1288 highlights why this behaviour is problematic.
`LATEST_INSTALLED_BUILD_TOOLS` config variable was completely removed in favour of `BUILD_TOOLS_VERSION`
The above changes were made in effort to not introduce anything breaking.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Ran npm test successfully.
Manually testing the following cases:
- Default configuration, latest build tools version `29` errors out as expected (min 30.0.3)
- Default configuration, latest build tools version `30.0.3` runs successfully.
- Default configuration, latest build tools version `31` errors out as expected (31 introduces breaking changes, so we don't support 31)
- `android-buildtoolsversion` preference 29, errors out as expected (min 30.0.3)
- `android-buildtoolsversion` preference 30.0.3 runs successfully
- `--gradleArg=-PcdvBuildToolsVersion=29.0.3` errors out as expected (min 30.0.3)
- `--gradleArg=-PcdvBuildToolsVersion=30.0.3` runs successfully
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1293: fix: gradle build tools config
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1293:
URL: https://github.com/apache/cordova-android/pull/1293#issuecomment-886846485
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1293](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a33ef91) into [master](https://codecov.io/gh/apache/cordova-android/commit/5e50c1d611e762b2d6e5eceb625994353e6d1f83?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e50c1d) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1293 +/- ##
=======================================
Coverage 73.25% 73.25%
=======================================
Files 21 21
Lines 1645 1645
=======================================
Hits 1205 1205
Misses 440 440
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5e50c1d...a33ef91](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1293: fix: gradle build tools config
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1293:
URL: https://github.com/apache/cordova-android/pull/1293#issuecomment-886846485
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1293](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a33ef91) into [master](https://codecov.io/gh/apache/cordova-android/commit/5e50c1d611e762b2d6e5eceb625994353e6d1f83?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e50c1d) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1293 +/- ##
=======================================
Coverage 73.25% 73.25%
=======================================
Files 21 21
Lines 1645 1645
=======================================
Hits 1205 1205
Misses 440 440
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5e50c1d...a33ef91](https://codecov.io/gh/apache/cordova-android/pull/1293?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #1293: fix: gradle build tools config
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1293:
URL: https://github.com/apache/cordova-android/pull/1293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org