[GitHub] [airflow] bbovenzi commented on pull request #26457: Add user comment to task instance and dag run

[GitBox <gi...@apache.org>]

bbovenzi commented on PR #26457:
URL: https://github.com/apache/airflow/pull/26457#issuecomment-1261049173

   This is looking great. After testing it out locally I have two suggestions.
   
   1. Once clicking on on "change note" or "set note" let's autofocus to the textarea. https://bobbyhadz.com/blog/react-focus-input-on-element
   
   2. Idk if I actually like the accordion. If we keep it, let's show the start of the note (cutting off long notes with an ellipsis). For short notes, its quite annoying to have to expand the accordion just for a short message that coudl easily fit in the white space.
   <img width="749" alt="Screen Shot 2022-09-28 at 10 58 50 AM" src="https://user-images.githubusercontent.com/4600967/192814012-1385095a-1803-498b-9a01-e1c3d4c6c53f.png">
   <img width="738" alt="Screen Shot 2022-09-28 at 10 58 53 AM" src="https://user-images.githubusercontent.com/4600967/192814013-8ea3b5bd-67e9-472d-8491-95b2da4b4c1f.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org