You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Brock Noland <br...@cloudera.com> on 2012/09/10 17:15:52 UTC
Review Request: FLUME-1553: TestFileChannelEncrytion should be refactored to
use TestFileChannelBase
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6983/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Simple refactor to eliminate extra code.
This addresses bug FLUME-1553.
https://issues.apache.org/jira/browse/FLUME-1553
Diffs
-----
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 7c1aaab
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java 4655978
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelFormatRegression.java 8fc0faf
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java cf61aed
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRollback.java 5b1a088
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryption.java 7d7a825
Diff: https://reviews.apache.org/r/6983/diff/
Testing
-------
Unit tests pass
Thanks,
Brock Noland
Re: Review Request: FLUME-1553: TestFileChannelEncrytion should be
refactored to use TestFileChannelBase
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6983/#review11292
-----------------------------------------------------------
Ship it!
Ship It!
- Hari Shreedharan
On Sept. 10, 2012, 3:15 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6983/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2012, 3:15 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Simple refactor to eliminate extra code.
>
>
> This addresses bug FLUME-1553.
> https://issues.apache.org/jira/browse/FLUME-1553
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 7c1aaab
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java 4655978
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelFormatRegression.java 8fc0faf
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java cf61aed
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRollback.java 5b1a088
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryption.java 7d7a825
>
> Diff: https://reviews.apache.org/r/6983/diff/
>
>
> Testing
> -------
>
> Unit tests pass
>
>
> Thanks,
>
> Brock Noland
>
>