[GitHub] [groovy] paulk-asert commented on pull request #1915: Set dgm operations

["paulk-asert (via GitHub)" <gi...@apache.org>]

paulk-asert commented on PR #1915:
URL: https://github.com/apache/groovy/pull/1915#issuecomment-1634151992

   I like this PR. Could you create a Jira ticket for it also to make it easier for tracking. My suggestions for the PR:
   
   - Let's stick with [Sorted]Set for the self/left parameter (since we already have `plus`/`intersect` for `Iterable`)
   - We already use `and`, `or`, and `xor` for `BitSet`, so let's stick with `xor` rather than `symmetricDiff`
   - I'd suggest `Iterable` as the second parameter like we use for `plus`, `minus` and `intersect`
   - I'd suggest additional variants of all methods taking an extra `Comparator` like we do for `intersect`, this would allow the default `NumberAwareComparator` to be skipped if desired although only using the longhand syntax, e.g. `assert [1,2,5,6] as Set == ([1,2,3,4] as Set).xor([3,4,5,6], Comparator.naturalOrder())`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org