You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2025/04/18 03:48:21 UTC
[PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
amorynan opened a new pull request, #50162:
URL: https://github.com/apache/doris/pull/50162
### What problem does this PR solve?
Fix types that do not support indexing. Types in array nesting should also not be supported.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50162:
URL: https://github.com/apache/doris/pull/50162#issuecomment-2814472302
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #50162:
URL: https://github.com/apache/doris/pull/50162#issuecomment-2832936083
branch-2.1 no need to pick this fix. because it has already check already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50162:
URL: https://github.com/apache/doris/pull/50162#issuecomment-2814480078
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50162:
URL: https://github.com/apache/doris/pull/50162#issuecomment-2814929393
<details>
<summary>TPC-DS: <b>Total hot run time: 192512 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 53fd2df73f76465d17f01e853adbb8c285e0ee10, data reload: false
query1 1402 1087 1075 1075
query2 6108 1733 1768 1733
query3 11127 4750 4644 4644
query4 55227 25002 23385 23385
query5 4899 534 458 458
query6 348 206 207 206
query7 4878 498 294 294
query8 317 254 243 243
query9 5682 2546 2558 2546
query10 399 329 267 267
query11 15552 15027 15010 15010
query12 158 110 105 105
query13 1025 507 385 385
query14 10530 6396 6342 6342
query15 210 188 179 179
query16 7165 687 478 478
query17 1097 730 598 598
query18 1566 401 317 317
query19 196 196 164 164
query20 125 132 116 116
query21 204 126 106 106
query22 4352 4507 4297 4297
query23 33896 33176 33410 33176
query24 6584 2380 2405 2380
query25 478 489 426 426
query26 693 290 159 159
query27 2064 485 364 364
query28 2859 2137 2140 2137
query29 577 577 437 437
query30 283 235 193 193
query31 840 859 796 796
query32 75 63 60 60
query33 442 387 313 313
query34 775 881 500 500
query35 809 848 765 765
query36 943 995 907 907
query37 111 97 82 82
query38 4198 4294 4182 4182
query39 1477 1460 1443 1443
query40 211 126 108 108
query41 55 53 50 50
query42 126 109 110 109
query43 498 510 483 483
query44 1355 816 828 816
query45 193 180 177 177
query46 837 1146 644 644
query47 1815 1905 1798 1798
query48 404 420 295 295
query49 700 557 444 444
query50 661 690 409 409
query51 4244 4320 4157 4157
query52 118 116 100 100
query53 252 263 195 195
query54 624 595 524 524
query55 97 88 85 85
query56 318 330 327 327
query57 1186 1192 1128 1128
query58 272 270 282 270
query59 2805 2768 2588 2588
query60 346 351 347 347
query61 157 175 126 126
query62 732 719 680 680
query63 226 187 189 187
query64 1737 1056 738 738
query65 4369 4211 4197 4197
query66 707 406 303 303
query67 15618 15576 15277 15277
query68 7193 820 509 509
query69 538 301 265 265
query70 1187 1097 1090 1090
query71 514 329 282 282
query72 5882 4969 4917 4917
query73 1532 719 342 342
query74 8933 9068 8959 8959
query75 3894 3186 2661 2661
query76 4129 1191 738 738
query77 641 367 292 292
query78 9895 9988 9262 9262
query79 2802 806 555 555
query80 629 507 441 441
query81 493 245 223 223
query82 477 128 95 95
query83 329 251 235 235
query84 286 96 85 85
query85 793 351 313 313
query86 350 303 290 290
query87 4435 4401 4258 4258
query88 3532 2221 2215 2215
query89 406 315 286 286
query90 1923 212 218 212
query91 141 138 111 111
query92 71 59 57 57
query93 1454 943 579 579
query94 671 419 309 309
query95 371 309 285 285
query96 479 566 270 270
query97 3107 3260 3079 3079
query98 239 207 197 197
query99 1408 1399 1270 1270
Total cold run time: 299068 ms
Total hot run time: 192512 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50162:
URL: https://github.com/apache/doris/pull/50162#issuecomment-2817465352
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #50162:
URL: https://github.com/apache/doris/pull/50162#issuecomment-2832966471
2.1 not have this problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #50162:
URL: https://github.com/apache/doris/pull/50162#issuecomment-2814472658
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #50162:
URL: https://github.com/apache/doris/pull/50162#issuecomment-2814693528
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50162:
URL: https://github.com/apache/doris/pull/50162#issuecomment-2814937099
<details>
<summary>ClickBench: <b>Total hot run time: 29.87 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 53fd2df73f76465d17f01e853adbb8c285e0ee10, data reload: false
query1 0.04 0.04 0.04
query2 0.12 0.10 0.10
query3 0.25 0.19 0.20
query4 1.59 0.20 0.18
query5 0.56 0.56 0.54
query6 1.18 0.72 0.72
query7 0.02 0.02 0.02
query8 0.04 0.03 0.03
query9 0.58 0.52 0.52
query10 0.57 0.57 0.56
query11 0.16 0.11 0.10
query12 0.15 0.11 0.11
query13 0.62 0.60 0.60
query14 1.15 1.25 1.17
query15 0.91 0.86 0.87
query16 0.38 0.39 0.38
query17 1.01 1.06 1.03
query18 0.22 0.21 0.20
query19 1.96 1.79 1.74
query20 0.02 0.01 0.01
query21 15.40 0.92 0.54
query22 0.77 1.21 0.66
query23 14.91 1.40 0.60
query24 6.84 1.97 1.03
query25 0.52 0.25 0.08
query26 0.59 0.17 0.15
query27 0.06 0.05 0.04
query28 9.84 0.94 0.44
query29 12.53 4.11 3.42
query30 0.26 0.09 0.06
query31 2.83 0.61 0.39
query32 3.22 0.55 0.48
query33 3.00 3.04 3.17
query34 15.80 5.13 4.47
query35 4.56 4.55 4.56
query36 0.67 0.51 0.49
query37 0.09 0.07 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.02
query40 0.17 0.14 0.14
query41 0.08 0.03 0.02
query42 0.03 0.03 0.02
query43 0.03 0.03 0.03
Total cold run time: 103.81 s
Total hot run time: 29.87 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50162:
URL: https://github.com/apache/doris/pull/50162#issuecomment-2814908482
<details>
<summary>TPC-H: <b>Total hot run time: 34046 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 53fd2df73f76465d17f01e853adbb8c285e0ee10, data reload: false
------ Round 1 ----------------------------------
q1 26405 5127 5052 5052
q2 2064 286 188 188
q3 10410 1263 733 733
q4 10213 1009 553 553
q5 7592 2383 2370 2370
q6 180 161 134 134
q7 929 740 601 601
q8 9323 1291 1054 1054
q9 6807 5146 5113 5113
q10 6882 2309 1879 1879
q11 478 281 269 269
q12 351 346 220 220
q13 17778 3709 3147 3147
q14 230 224 217 217
q15 549 501 491 491
q16 449 459 400 400
q17 605 864 365 365
q18 7755 7344 7045 7045
q19 2093 967 560 560
q20 336 330 221 221
q21 3929 3366 2469 2469
q22 1025 1045 965 965
Total cold run time: 116383 ms
Total hot run time: 34046 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5270 5118 5088 5088
q2 241 330 237 237
q3 2184 2666 2298 2298
q4 1484 1865 1558 1558
q5 4448 4389 4393 4389
q6 223 167 131 131
q7 1992 1929 1744 1744
q8 2634 2596 2501 2501
q9 7276 7222 6996 6996
q10 2994 3206 2729 2729
q11 576 516 490 490
q12 677 775 601 601
q13 3592 3939 3288 3288
q14 291 320 279 279
q15 536 493 474 474
q16 470 509 477 477
q17 1186 1562 1407 1407
q18 7824 7782 7691 7691
q19 822 822 841 822
q20 2036 2022 1829 1829
q21 5278 4832 4967 4832
q22 1120 1059 1058 1058
Total cold run time: 53154 ms
Total hot run time: 50919 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50162:
URL: https://github.com/apache/doris/pull/50162#issuecomment-2814480117
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #50162:
URL: https://github.com/apache/doris/pull/50162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org