[GitHub] chetanmeh opened a new pull request #4157: Make query limits configurable

[GitBox <gi...@apache.org>]

chetanmeh opened a new pull request #4157: Make query limits configurable
URL: https://github.com/apache/incubator-openwhisk/pull/4157
 
 
   Make limits related to list operation against entities configurable. 
   
   
   ## Description
   
   Currently the queries related to collections (used while doing list operation) make use of hard coded limits. 
   
   ### Impact due to wsk activation poll
   
   For example if `limit=0` in list operation then it uses 200 has the default value. This is used in `wsk activation poll` which by default generates a GET request like
   
   ```
   /api/v1/namespaces/_/activations?docs=true&limit=0&since=1542422386538&skip=0
   ```
   
   Currently the poll command once started "probably" sticks to start time and we have seen user leaving such poll running for days (often left in one of the numerous tabs!) which causes the system to pull similar 200 records over and over.
   
   ### CosmosDB and higher resource usage
   
   Further in our case (using CosmosDB) which does client side merging of query results a sorted query gets executed like below
   
   1. Initial ask to fetch 200 records
   2. SDK makes call to each partition to fetch query record with limit
     - If limit > default maxItemPerPageCount use maxItemPerPageCount i.e. 100
     - If limit < then use the limit
   3. Perform a merge sort on client side
   
   In such a case at times we have seen for listing 200 records SDK fetch ~ 900 records causing higher resource usage on db side
   
   To reduce impact for such cases I would like to have these limits configurable
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services