You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by ly...@apache.org on 2023/11/03 03:05:25 UTC
(incubator-devlake) branch main updated: fix(framework): remove deprecated fields in domain layer (#6393)
This is an automated email from the ASF dual-hosted git repository.
lynwee pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/main by this push:
new 0985f68ea fix(framework): remove deprecated fields in domain layer (#6393)
0985f68ea is described below
commit 0985f68ead4d30572c53ef23b9871ca1e5db51df
Author: Lynwee <li...@merico.dev>
AuthorDate: Fri Nov 3 11:05:20 2023 +0800
fix(framework): remove deprecated fields in domain layer (#6393)
* fix(framework): remove deprecated fields in domain layer
* fix(framework): fix typo
* refactor(framework): remove Position from backend
* fix(gitlab): fix e2e test
---
.../domainlayer/code/pull_request_comment.go | 1 -
..._remove_position_from_pull_request_comments.go} | 35 +++---
backend/core/models/migrationscripts/register.go | 1 +
backend/plugins/bitbucket/e2e/comment_test.go | 1 -
.../e2e/snapshot_tables/pull_request_comments.csv | 38 +++----
.../bitbucket/tasks/pr_comment_convertor.go | 1 -
.../plugins/gitee/tasks/pr_comment_convertor.go | 1 -
backend/plugins/github/e2e/comment_test.go | 1 -
backend/plugins/github/e2e/pr_review_test.go | 1 -
.../e2e/snapshot_tables/pull_request_comments.csv | 126 ++++++++++-----------
.../pull_request_review_comments.csv | 62 +++++-----
backend/plugins/gitlab/e2e/mr_notes_test.go | 1 -
.../e2e/snapshot_tables/pull_request_comments.csv | 22 ++--
.../pydevlake/pydevlake/domain_layer/code.py | 1 -
14 files changed, 138 insertions(+), 154 deletions(-)
diff --git a/backend/core/models/domainlayer/code/pull_request_comment.go b/backend/core/models/domainlayer/code/pull_request_comment.go
index 05aca3460..bfe0db18c 100644
--- a/backend/core/models/domainlayer/code/pull_request_comment.go
+++ b/backend/core/models/domainlayer/code/pull_request_comment.go
@@ -30,7 +30,6 @@ type PullRequestComment struct {
AccountId string `gorm:"type:varchar(255)"`
CreatedDate time.Time
CommitSha string `gorm:"type:varchar(255)"`
- Position int
Type string `gorm:"type:varchar(255)"`
ReviewId string `gorm:"type:varchar(255)"`
Status string `gorm:"type:varchar(255)"`
diff --git a/backend/core/models/domainlayer/code/pull_request_comment.go b/backend/core/models/migrationscripts/20231103_remove_position_from_pull_request_comments.go
similarity index 53%
copy from backend/core/models/domainlayer/code/pull_request_comment.go
copy to backend/core/models/migrationscripts/20231103_remove_position_from_pull_request_comments.go
index 05aca3460..eecd40700 100644
--- a/backend/core/models/domainlayer/code/pull_request_comment.go
+++ b/backend/core/models/migrationscripts/20231103_remove_position_from_pull_request_comments.go
@@ -15,33 +15,24 @@ See the License for the specific language governing permissions and
limitations under the License.
*/
-package code
+package migrationscripts
import (
- "time"
-
- "github.com/apache/incubator-devlake/core/models/domainlayer"
+ "github.com/apache/incubator-devlake/core/context"
+ "github.com/apache/incubator-devlake/core/errors"
+ "github.com/apache/incubator-devlake/core/models/migrationscripts/archived"
)
-type PullRequestComment struct {
- domainlayer.DomainEntity
- PullRequestId string `gorm:"index;varchar(255)"`
- Body string
- AccountId string `gorm:"type:varchar(255)"`
- CreatedDate time.Time
- CommitSha string `gorm:"type:varchar(255)"`
- Position int
- Type string `gorm:"type:varchar(255)"`
- ReviewId string `gorm:"type:varchar(255)"`
- Status string `gorm:"type:varchar(255)"`
+type removePositionFromPullRequestComments struct{}
+
+func (u *removePositionFromPullRequestComments) Up(basicRes context.BasicRes) errors.Error {
+ return basicRes.GetDal().DropColumns(archived.PullRequestComment{}.TableName(), "position")
}
-func (PullRequestComment) TableName() string {
- return "pull_request_comments"
+func (*removePositionFromPullRequestComments) Version() uint64 {
+ return 20231103102700
}
-const (
- NORMAL_COMMENT = "NORMAL"
- DIFF_COMMENT = "DIFF"
- REVIEW = "REVIEW"
-)
+func (*removePositionFromPullRequestComments) Name() string {
+ return "remove position field from pull_request_comments"
+}
diff --git a/backend/core/models/migrationscripts/register.go b/backend/core/models/migrationscripts/register.go
index 647a27020..6e4e78c64 100644
--- a/backend/core/models/migrationscripts/register.go
+++ b/backend/core/models/migrationscripts/register.go
@@ -95,5 +95,6 @@ func All() []plugin.MigrationScript {
new(normalizeBpSettings),
new(addSyncPolicy),
new(addIssueCustomArrayField),
+ new(removePositionFromPullRequestComments),
}
}
diff --git a/backend/plugins/bitbucket/e2e/comment_test.go b/backend/plugins/bitbucket/e2e/comment_test.go
index 64d0f4bc5..b282de5e5 100644
--- a/backend/plugins/bitbucket/e2e/comment_test.go
+++ b/backend/plugins/bitbucket/e2e/comment_test.go
@@ -128,7 +128,6 @@ func TestCommentDataFlow(t *testing.T) {
"body",
"account_id",
"commit_sha",
- "position",
"type",
"review_id",
"status",
diff --git a/backend/plugins/bitbucket/e2e/snapshot_tables/pull_request_comments.csv b/backend/plugins/bitbucket/e2e/snapshot_tables/pull_request_comments.csv
index 9ddc97b5f..520f40da8 100644
--- a/backend/plugins/bitbucket/e2e/snapshot_tables/pull_request_comments.csv
+++ b/backend/plugins/bitbucket/e2e/snapshot_tables/pull_request_comments.csv
@@ -1,21 +1,21 @@
-id,pull_request_id,body,account_id,commit_sha,position,type,review_id,status,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
-bitbucket:BitbucketPrComment:1:323119643,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:54,this is test014,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,14,
-bitbucket:BitbucketPrComment:1:323119662,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:54,feafjae,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,15,
+id,pull_request_id,body,account_id,commit_sha,type,review_id,status,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
+bitbucket:BitbucketPrComment:1:323119643,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:54,this is test014,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,14,
+bitbucket:BitbucketPrComment:1:323119662,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:54,feafjae,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,15,
bitbucket:BitbucketPrComment:1:323119730,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:57,"fejoiafjoej
-",bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,17,
-bitbucket:BitbucketPrComment:1:323119743,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:57,fjeafojeoirjgoar,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,18,
-bitbucket:BitbucketPrComment:1:323119784,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:51,fejoafefewa,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,12,
-bitbucket:BitbucketPrComment:1:323119790,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:51,feafeogioehrw,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,13,
-bitbucket:BitbucketPrComment:1:323119842,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:42,feafoegoaweoir,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,8,
-bitbucket:BitbucketPrComment:1:323119856,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:42,boroehruheorefe,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,9,
-bitbucket:BitbucketPrComment:1:323119897,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:54,feajfweofjwvgrea,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,16,
-bitbucket:BitbucketPrComment:1:323119960,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:38,regrioteothro,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,4,
-bitbucket:BitbucketPrComment:1:323119980,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:38,goeotbioebhotn,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,5,
-bitbucket:BitbucketPrComment:1:323120091,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:44,feawrjoiw,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,10,
-bitbucket:BitbucketPrComment:1:323120101,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:44,bbeirobeoiahoa,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,11,
-bitbucket:BitbucketPrComment:1:323120140,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:40,evbnoera,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,6,
-bitbucket:BitbucketPrComment:1:323120196,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:41,vobreia,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,7,
-bitbucket:BitbucketPrComment:1:323120278,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:31,baroboerhba,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,1,
-bitbucket:BitbucketPrComment:1:323120296,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:31,bweiwbeanb,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,2,
-bitbucket:BitbucketPrComment:1:323120311,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:31,jbirobsore,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,0,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,3,
+",bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,17,
+bitbucket:BitbucketPrComment:1:323119743,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:57,fjeafojeoirjgoar,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,18,
+bitbucket:BitbucketPrComment:1:323119784,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:51,fejoafefewa,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,12,
+bitbucket:BitbucketPrComment:1:323119790,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:51,feafeogioehrw,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,13,
+bitbucket:BitbucketPrComment:1:323119842,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:42,feafoegoaweoir,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,8,
+bitbucket:BitbucketPrComment:1:323119856,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:42,boroehruheorefe,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,9,
+bitbucket:BitbucketPrComment:1:323119897,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:54,feajfweofjwvgrea,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,16,
+bitbucket:BitbucketPrComment:1:323119960,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:38,regrioteothro,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,4,
+bitbucket:BitbucketPrComment:1:323119980,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:38,goeotbioebhotn,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,5,
+bitbucket:BitbucketPrComment:1:323120091,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:44,feawrjoiw,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,10,
+bitbucket:BitbucketPrComment:1:323120101,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:44,bbeirobeoiahoa,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,11,
+bitbucket:BitbucketPrComment:1:323120140,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:40,evbnoera,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,6,
+bitbucket:BitbucketPrComment:1:323120196,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:41,vobreia,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,7,
+bitbucket:BitbucketPrComment:1:323120278,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:31,baroboerhba,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,1,
+bitbucket:BitbucketPrComment:1:323120296,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:31,bweiwbeanb,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,2,
+bitbucket:BitbucketPrComment:1:323120311,bitbucket:BitbucketPullRequest:1:likyh/likyhphp:31,jbirobsore,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,pullrequest_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_pull_request_comments,3,
diff --git a/backend/plugins/bitbucket/tasks/pr_comment_convertor.go b/backend/plugins/bitbucket/tasks/pr_comment_convertor.go
index da970375b..4c67ba83b 100644
--- a/backend/plugins/bitbucket/tasks/pr_comment_convertor.go
+++ b/backend/plugins/bitbucket/tasks/pr_comment_convertor.go
@@ -71,7 +71,6 @@ func ConvertPullRequestComments(taskCtx plugin.SubTaskContext) errors.Error {
Body: prComment.Body,
Type: prComment.Type,
CommitSha: "",
- Position: 0,
}
return []interface{}{
domainPrComment,
diff --git a/backend/plugins/gitee/tasks/pr_comment_convertor.go b/backend/plugins/gitee/tasks/pr_comment_convertor.go
index e01c230c7..445ac5c1b 100644
--- a/backend/plugins/gitee/tasks/pr_comment_convertor.go
+++ b/backend/plugins/gitee/tasks/pr_comment_convertor.go
@@ -71,7 +71,6 @@ func ConvertPullRequestComments(taskCtx plugin.SubTaskContext) errors.Error {
AccountId: accountIdGen.Generate(data.Options.ConnectionId, giteePullRequestComment.AuthorUserId),
CreatedDate: giteePullRequestComment.GiteeCreatedAt,
CommitSha: "",
- Position: 0,
}
return []interface{}{
domainPrComment,
diff --git a/backend/plugins/github/e2e/comment_test.go b/backend/plugins/github/e2e/comment_test.go
index 36fd6f340..5be31ce3d 100644
--- a/backend/plugins/github/e2e/comment_test.go
+++ b/backend/plugins/github/e2e/comment_test.go
@@ -155,7 +155,6 @@ func TestCommentDataFlow(t *testing.T) {
"account_id",
"created_date",
"commit_sha",
- "position",
"type",
"review_id",
"status",
diff --git a/backend/plugins/github/e2e/pr_review_test.go b/backend/plugins/github/e2e/pr_review_test.go
index abfaa61e0..10c364e06 100644
--- a/backend/plugins/github/e2e/pr_review_test.go
+++ b/backend/plugins/github/e2e/pr_review_test.go
@@ -92,7 +92,6 @@ func TestPrReviewDataFlow(t *testing.T) {
"account_id",
"created_date",
"commit_sha",
- "position",
"type",
"review_id",
"status",
diff --git a/backend/plugins/github/e2e/snapshot_tables/pull_request_comments.csv b/backend/plugins/github/e2e/snapshot_tables/pull_request_comments.csv
index 1e002292b..db424f114 100644
--- a/backend/plugins/github/e2e/snapshot_tables/pull_request_comments.csv
+++ b/backend/plugins/github/e2e/snapshot_tables/pull_request_comments.csv
@@ -1,63 +1,63 @@
-id,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark,pull_request_id,body,account_id,created_date,commit_sha,position,type,review_id,status
-github:GithubPrComment:1:300245643,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,1,,github:GithubPullRequest:1:292246524,""" chinese ， chinese goroutine chinese ？""",github:GithubAccount:1:7496278,2019-07-04T06:32:11.000+00:00,39f04c6e65b76b5f20abd3ca0606db4cd038e5c2,0,DIFF,github:GithubPrReview:1:257849164,
-github:GithubPrComment:1:300246398,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,2,,github:GithubPullRequest:1:292246524,"""`f()` chinese ？""",github:GithubAccount:1:7496278,2019-07-04T06:35:07.000+00:00,39f04c6e65b76b5f20abd3ca0606db4cd038e5c2,0,DIFF,github:GithubPrReview:1:257849164,
-github:GithubPrComment:1:307667007,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,3,,github:GithubPullRequest:1:301421607,"""I don't think assigning this variable to a oversize value is a good idea, threre are different scenarios which should have different interval durations to clean up goroutines, so could you please make `DEFAULT_CLEAN_INTERVAL_TIME ` configurable? Maybe adding a new function that accepts this variable as its argument." [...]
-github:GithubPrComment:1:307667451,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,4,,github:GithubPullRequest:1:301421607,"""I believe you should add new unit tests for your new feature.""",github:GithubAccount:1:7496278,2019-07-26T09:39:24.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,0,DIFF,github:GithubPrReview:1:267089136,
-github:GithubPrComment:1:307669178,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,5,,github:GithubPullRequest:1:301421607,"""You omitted the `worker_func.go`, please update it.""",github:GithubAccount:1:7496278,2019-07-26T09:43:56.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,0,DIFF,github:GithubPrReview:1:267089136,
-github:GithubPrComment:1:307671676,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,6,,github:GithubPullRequest:1:301421607,"""got it""",github:GithubAccount:1:17495446,2019-07-26T09:50:06.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,0,DIFF,github:GithubPrReview:1:267094793,
-github:GithubPrComment:1:307672146,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,7,,github:GithubPullRequest:1:301421607,"""sure, I will add.""",github:GithubAccount:1:17495446,2019-07-26T09:51:31.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,0,DIFF,github:GithubPrReview:1:267095424,
-github:GithubPrComment:1:307672417,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,8,,github:GithubPullRequest:1:301421607,"""I will think about it""",github:GithubAccount:1:17495446,2019-07-26T09:52:20.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,0,DIFF,github:GithubPrReview:1:267095785,
-github:GithubPrComment:1:307675200,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,9,,github:GithubPullRequest:1:301421607,""" When the pool size is too large , Performance will drop by the lock . Locking at high concurrency is like an atomic bomb. So I think it should be changed. Because it's the default pool value. Many user will use self-defined pool by NewPool. Of course, it is ok to not change.\r\n""",github:GithubAccount:1:17495446,2 [...]
-github:GithubPrComment:1:307686223,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,10,,github:GithubPullRequest:1:301421607,"""I think we can modify the New method and periodicallyPurge, it can be used as the next enhancement. I restored it for this pr. May it can be another pr for this.""",github:GithubAccount:1:17495446,2019-07-26T10:33:56.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,0,DIFF,github:GithubPrReview:1:267113847,
-github:GithubPrComment:1:315493235,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,11,,github:GithubPullRequest:1:308859272,"""SA2002: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (from `staticcheck`)""",github:GithubAccount:1:42910462,2019-08-20T03:25:26.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,0,DIFF,github:GithubPrReview:1:276914383,
-github:GithubPrComment:1:315497949,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,12,,github:GithubPullRequest:1:308859272,"""Are these two fields of `MaxBlockingSubmit` and `blockingNum` really necessary? From where I stand, the throttle of your business traffics should be the capacity of pool, if you've set up `nonblocking` as `true`, it returns nil once the amount of all running workers reaches the pool capacity, otherwise, it is blocke [...]
-github:GithubPrComment:1:315498393,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,13,,github:GithubPullRequest:1:308859272,"""This section could be refined as:\r\n```go\r\nif w := p.retrieveWorker(); w == nil {\r\n return ErrPoolBlocked\r\n} else {\r\n w.task <- task\r\n}\r\n```""",github:GithubAccount:1:7496278,2019-08-20T04:02:19.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,0,DIFF,github:GithubPrReview:1:276920486,
-github:GithubPrComment:1:315498823,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,14,,github:GithubPullRequest:1:308859272,"""The name of `ErrPoolBlocked` is blurry and unable to tell why it is being blocked, I would suggest `ErrPoolOverload` or `ErrPoolOverflow`.""",github:GithubAccount:1:7496278,2019-08-20T04:05:11.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,0,DIFF,github:GithubPrReview:1:276920486,
-github:GithubPrComment:1:315499067,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,15,,github:GithubPullRequest:1:308859272,"""If this field is necessary, rename it to `MaxBlockingTasks`.""",github:GithubAccount:1:7496278,2019-08-20T04:06:45.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,0,DIFF,github:GithubPrReview:1:276920486,
-github:GithubPrComment:1:315499281,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,16,,github:GithubPullRequest:1:308859272,"""I think `Nonblocking` is enough.""",github:GithubAccount:1:7496278,2019-08-20T04:08:21.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,0,DIFF,github:GithubPrReview:1:276920486,
-github:GithubPrComment:1:407675431,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3162,,github:GithubPullRequest:1:203756736,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/4?src=pr&el=h1) Report\n> Merging [#4](https://codecov.io/gh/panjf2000/ants/pull/4?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/f5b37d0798a8e4c6780a1e08270fa50e979aa1d7?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[! [...]
-github:GithubPrComment:1:407714136,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3163,,github:GithubPullRequest:1:203756736,"""@barryz chinese ， chinese ， chinese ， chinese benchmark chinese 1000w chinese 7w chinese ， chinese 5w chinese ， chinese benchmark chinese ， chinese allocs/op chinese """,github:GithubAccount:1:7496278,2018-07-25T10:49:44.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:407755528,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3164,,github:GithubPullRequest:1:203756736,"""@panjf2000 chinese ， 1000W chinese goroutine chinese ， chinese ， chinese worker chinese ， chinese 。 chinese benchmark chinese \r\n\r\nmaster:\r\n\r\n```\r\ngoos: linux\r\ngoarch: amd64\r\nBenchmarkGoroutineWithFunc-4 1 15079030287 ns/op 723120296 B/op 10176159 allocs/op\r\nPASS\r\nok command-line-arg [...]
-github:GithubPrComment:1:407764945,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3165,,github:GithubPullRequest:1:203756736,"""@barryz chinese ， chinese ， chinese ， chinese ， chinese ， chinese ， chinese """,github:GithubAccount:1:7496278,2018-07-25T14:02:41.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:416794440,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3180,,github:GithubPullRequest:1:211603583,"""@hongli-my chinese ， chinese ？ chinese ？""",github:GithubAccount:1:7496278,2018-08-29T01:39:23.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:416794871,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3181,,github:GithubPullRequest:1:211603583,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/8?src=pr&el=h1) Report\n> Merging [#8](https://codecov.io/gh/panjf2000/ants/pull/8?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/666635c65d8d3bb1223b819325e0bd23c81f2733?src=pr&el=desc) will **decrease** coverage by `1.24%`.\n> The diff coverage is `100 [...]
-github:GithubPrComment:1:416803651,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3182,,github:GithubPullRequest:1:211603583,"""```n := 0\r\n\t\tfor i, w := range idleWorkers {\r\n\t\t\tif currentTime.Sub(w.recycleTime) <= p.expiryDuration {\r\n\t\t\t\tbreak\r\n\t\t\t}\r\n\t\t\tn = i\r\n\t\t\tw.args <- nil\r\n\t\t\tidleWorkers[i] = nil\r\n\t\t}\r\n\t\tn++\r\n\t\tif n >= len(idleWorkers) {\r\n\t\t\tp.workers = idleWorkers[:0]\r\n\t\t} else {\r\n\t\t\tp.workers [...]
-github:GithubPrComment:1:416818094,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3183,,github:GithubPullRequest:1:211603583,"""@hongli-my chinese ， chinese ， chinese ， chinese develop chinese ， chinese ， chinese ， chinese merge""",github:GithubAccount:1:7496278,2018-08-29T04:11:17.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:421884048,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3188,,github:GithubPullRequest:1:211603583,""" chinese worker chinese chan chinese close chinese ， chinese ， chinese """,github:GithubAccount:1:29241786,2018-09-17T03:37:44.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425423544,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3199,,github:GithubPullRequest:1:218939809,"""@liyonglion chinese ， chinese ：\r\n1. chinese pr， chinese ants_test.go chinese import ants chinese ；\r\n2. chinese pool.go chinese ， chinese pool_func.go chinese 。\r\n\r\n chinese pr， chinese ， chinese merge chinese 。""",github:GithubAccount:1:7496278,2018-09-28T12:43:30.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425428914,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3200,,github:GithubPullRequest:1:218939809,""" chinese ， chinese putWorker chinese ， chinese p.cond.Signal() chinese ，p.lock chinese ， chinese \r\n\r\n chinese ， chinese worker chinese ， chinese p.cond.Wait() chinese worker chinese ，len(p.workers) - 1 chinese -1， chinese [...]
-github:GithubPrComment:1:425431081,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3201,,github:GithubPullRequest:1:218939809,""" chinese 。 chinese ， chinese ， chinese 。""",github:GithubAccount:1:12890888,2018-09-28T13:12:08.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425432498,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3202,,github:GithubPullRequest:1:218939809,""" chinese ， chinese 。""",github:GithubAccount:1:7496278,2018-09-28T13:17:44.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425438107,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3203,,github:GithubPullRequest:1:218939809,""" chinese ， chinese 。 chinese ， chinese ，pool chinese 。""",github:GithubAccount:1:12890888,2018-09-28T13:37:48.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425439137,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3204,,github:GithubPullRequest:1:218939809,""" chinese ， chinese 。""",github:GithubAccount:1:12890888,2018-09-28T13:41:20.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425608265,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3205,,github:GithubPullRequest:1:218939809,""" chinese ， chinese 。 chinese """,github:GithubAccount:1:12890888,2018-09-29T02:22:39.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425609411,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3206,,github:GithubPullRequest:1:218939809,"""\r\n chinese ， chinese workers chinese ， chinese Travis CI chinese """,github:GithubAccount:1:7496278,2018-09-29T02:41:56.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425609608,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3207,,github:GithubPullRequest:1:218939809,""" chinese ， chinese 。 chinese """,github:GithubAccount:1:12890888,2018-09-29T02:45:23.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425622339,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3208,,github:GithubPullRequest:1:218939809,""" chinese ：\r\n100w chinese ，5w chinese goroutine\r\n\r\n\r\n\r\n""",github:GithubAccount:1:128908 [...]
-github:GithubPrComment:1:425622437,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3209,,github:GithubPullRequest:1:218939809,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/13?src=pr&el=h1) Report\n> Merging [#13](https://codecov.io/gh/panjf2000/ants/pull/13?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/af376f1b7b59dc488458bcecd4273f0fcde33c55?src=pr&el=desc) will **decrease** coverage by `90.38%`.\n> The diff coverage is [...]
-github:GithubPrComment:1:425623081,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3210,,github:GithubPullRequest:1:218939809,"""@panjf2000 chinese ？""",github:GithubAccount:1:12890888,2018-09-29T07:16:02.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425632550,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3211,,github:GithubPullRequest:1:218939809,""" chinese 。。。""",github:GithubAccount:1:7496278,2018-09-29T09:53:47.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425632613,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3212,,github:GithubPullRequest:1:218939809,""" chinese worker chinese """,github:GithubAccount:1:7496278,2018-09-29T09:54:48.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425632632,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3213,,github:GithubPullRequest:1:218939809,""" chinese 。。。。""",github:GithubAccount:1:12890888,2018-09-29T09:55:07.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425632777,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3214,,github:GithubPullRequest:1:218939809,"""@panjf2000 chinese ， chinese ？""",github:GithubAccount:1:12890888,2018-09-29T09:57:34.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425637776,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3215,,github:GithubPullRequest:1:218939809,"""@liyonglion chinese ， chinese ， chinese ， chinese 。。。""",github:GithubAccount:1:7496278,2018-09-29T11:25:56.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425637938,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3216,,github:GithubPullRequest:1:218939809,""" chinese ， chinese ， chinese import chinese ， chinese merge chinese """,github:GithubAccount:1:7496278,2018-09-29T11:29:28.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:425896318,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3217,,github:GithubPullRequest:1:219363161,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/14?src=pr&el=h1) Report\n> Merging [#14](https://codecov.io/gh/panjf2000/ants/pull/14?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/1b62696050b7030106291980d5220f886b017eff?src=pr&el=desc) will **decrease** coverage by `2.12%`.\n> The diff coverage is ` [...]
-github:GithubPrComment:1:425906970,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3218,,github:GithubPullRequest:1:219363161,"""thanks for your correction and could you also modify the pool_func.go cuz there is also the same useless statement in that file. i will accept this pr after your modification is done, thanks.""",github:GithubAccount:1:7496278,2018-10-01T13:27:04.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:426537013,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3219,,github:GithubPullRequest:1:219936521,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/15?src=pr&el=h1) Report\n> Merging [#15](https://codecov.io/gh/panjf2000/ants/pull/15?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/29730bb70343924a2f56a13a9799611dd1cd27fd?src=pr&el=desc) will **decrease** coverage by `0.84%`.\n> The diff coverage is ` [...]
-github:GithubPrComment:1:426596957,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3220,,github:GithubPullRequest:1:219936521,"""@egonelbre thanks for your interest in this repository and i got some puzzles.\r\nfirstly, i don't understand why you use both the chan struct{} and sync.WaitGroup at once, that seems a bit excessive cuz waitgroup and chan did the same thing.\r\nsecondly, method BenchmarkGoroutine was design to test throughput so it should run withou [...]
-github:GithubPrComment:1:426604764,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3221,,github:GithubPullRequest:1:219936521,"""Hi, semaphore acts as protection to avoid starting too many goroutines at once. `WaitGroup` is used to wait for everything to complete.\r\n\r\n`BenchmarkGoroutine` doesn't wait for all the goroutines to finish, so you are testing goroutine startup speed rather than throughput. It's somewhat unclear what you mean by \""throughput\"" i [...]
-github:GithubPrComment:1:429609579,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3222,,github:GithubPullRequest:1:222703171,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/16?src=pr&el=h1) Report\n> Merging [#16](https://codecov.io/gh/panjf2000/ants/pull/16?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/711dbdb7a222771ce15aaee1bb7b7c6e9731f208?src=pr&el=desc) will **decrease** coverage by `2.03%`.\n> The diff coverage is ` [...]
-github:GithubPrComment:1:433821356,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3223,,github:GithubPullRequest:1:211603583,""" chinese bugfix chinese ？""",github:GithubAccount:1:8923413,2018-10-29T08:10:59.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:434126048,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3224,,github:GithubPullRequest:1:211603583,"""@choleraehyq chinese pr chinese 。""",github:GithubAccount:1:7496278,2018-10-30T00:10:32.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:434126349,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3225,,github:GithubPullRequest:1:211603583,"""@MrDragon1122 chinese channel chinese close chinese ， chinese goroutine chinese channel， chinese 。""",github:GithubAccount:1:7496278,2018-10-30T00:12:13.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:439758381,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3226,,github:GithubPullRequest:1:231840723,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/19?src=pr&el=h1) Report\n> Merging [#19](https://codecov.io/gh/panjf2000/ants/pull/19?src=pr&el=desc) into [develop](https://codecov.io/gh/panjf2000/ants/commit/92acf74bb71c1dc1758c61346c88325284978b3e?src=pr&el=desc) will **increase** coverage by `0.02%`.\n> The diff coverage is [...]
-github:GithubPrComment:1:439758480,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3227,,github:GithubPullRequest:1:231840723,""" chinese \r\n chinese \r\nants.NewPoolWithFunc()\r\n chinese \r\n chinese Resize(0) && Release\r\n chinese ， chinese NewTicker chinese Stop chinese \r\n\r\nflat flat% sum% cum cum%\r\n\r\n 7168.57kB 77.60% 77.60% 7168.57kB 77.60% time.NewTicker\r\n\r\n\r\n\r\n""",github:GithubAccount:1:7931755,2018-11-19T03:06:50.000+00 [...]
-github:GithubPrComment:1:439781607,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3228,,github:GithubPullRequest:1:231840723,""" chinese PR chinese ， chinese PR chinese """,github:GithubAccount:1:7931755,2018-11-19T06:07:43.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:439793352,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3230,,github:GithubPullRequest:1:231840723,""" chinese pr chinese ， chinese failed chinese ， chinese merge， chinese ？ chinese pr chinese 。""",github:GithubAccount:1:7496278,2018-11-19T07:14:58.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:456033956,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3246,,github:GithubPullRequest:1:246250598,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/23?src=pr&el=h1) Report\n> Merging [#23](https://codecov.io/gh/panjf2000/ants/pull/23?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/812dd4e01075be3cf97429a43abaf6837908cdcd?src=pr&el=desc) will **decrease** coverage by `1.02%`.\n> The diff coverage is ` [...]
-github:GithubPrComment:1:456071084,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3247,,github:GithubPullRequest:1:246250598,"""@choleraehyq \r\nbuild chinese ， chinese ？""",github:GithubAccount:1:7496278,2019-01-21T13:18:19.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:456261758,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3248,,github:GithubPullRequest:1:246250598,"""@panjf2000 chinese ， chinese PanicHandler chinese ， chinese panic chinese ， chinese worker chinese panic， chinese recover""",github:GithubAccount:1:8923413,2019-01-22T03:45:04.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:456270386,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3249,,github:GithubPullRequest:1:246250598,"""@choleraehyq \r\n chinese ：\r\n1. CI failed chinese TestPanicHandler chinese \r\n\r\n2. chinese Worker chinese recover chinese ， chinese w.pool.decRunning()， chinese panic chinese goroutine chinese ， chinese pool chinese work [...]
-github:GithubPrComment:1:456273052,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3250,,github:GithubPullRequest:1:246250598,"""@panjf2000 thanks， chinese """,github:GithubAccount:1:8923413,2019-01-22T05:10:00.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
-github:GithubPrComment:1:456277710,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3251,,github:GithubPullRequest:1:246250598,"""Thanks for your contributions to `ants`!""",github:GithubAccount:1:7496278,2019-01-22T05:41:10.000+00:00,,0,NORMAL,github:GithubPrReview:1:0,
+id,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark,pull_request_id,body,account_id,created_date,commit_sha,type,review_id,status
+github:GithubPrComment:1:300245643,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,1,,github:GithubPullRequest:1:292246524,""" chinese ， chinese goroutine chinese ？""",github:GithubAccount:1:7496278,2019-07-04T06:32:11.000+00:00,39f04c6e65b76b5f20abd3ca0606db4cd038e5c2,DIFF,github:GithubPrReview:1:257849164,
+github:GithubPrComment:1:300246398,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,2,,github:GithubPullRequest:1:292246524,"""`f()` chinese ？""",github:GithubAccount:1:7496278,2019-07-04T06:35:07.000+00:00,39f04c6e65b76b5f20abd3ca0606db4cd038e5c2,DIFF,github:GithubPrReview:1:257849164,
+github:GithubPrComment:1:307667007,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,3,,github:GithubPullRequest:1:301421607,"""I don't think assigning this variable to a oversize value is a good idea, threre are different scenarios which should have different interval durations to clean up goroutines, so could you please make `DEFAULT_CLEAN_INTERVAL_TIME ` configurable? Maybe adding a new function that accepts this variable as its argument." [...]
+github:GithubPrComment:1:307667451,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,4,,github:GithubPullRequest:1:301421607,"""I believe you should add new unit tests for your new feature.""",github:GithubAccount:1:7496278,2019-07-26T09:39:24.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,DIFF,github:GithubPrReview:1:267089136,
+github:GithubPrComment:1:307669178,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,5,,github:GithubPullRequest:1:301421607,"""You omitted the `worker_func.go`, please update it.""",github:GithubAccount:1:7496278,2019-07-26T09:43:56.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,DIFF,github:GithubPrReview:1:267089136,
+github:GithubPrComment:1:307671676,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,6,,github:GithubPullRequest:1:301421607,"""got it""",github:GithubAccount:1:17495446,2019-07-26T09:50:06.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,DIFF,github:GithubPrReview:1:267094793,
+github:GithubPrComment:1:307672146,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,7,,github:GithubPullRequest:1:301421607,"""sure, I will add.""",github:GithubAccount:1:17495446,2019-07-26T09:51:31.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,DIFF,github:GithubPrReview:1:267095424,
+github:GithubPrComment:1:307672417,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,8,,github:GithubPullRequest:1:301421607,"""I will think about it""",github:GithubAccount:1:17495446,2019-07-26T09:52:20.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,DIFF,github:GithubPrReview:1:267095785,
+github:GithubPrComment:1:307675200,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,9,,github:GithubPullRequest:1:301421607,""" When the pool size is too large , Performance will drop by the lock . Locking at high concurrency is like an atomic bomb. So I think it should be changed. Because it's the default pool value. Many user will use self-defined pool by NewPool. Of course, it is ok to not change.\r\n""",github:GithubAccount:1:17495446,2 [...]
+github:GithubPrComment:1:307686223,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,10,,github:GithubPullRequest:1:301421607,"""I think we can modify the New method and periodicallyPurge, it can be used as the next enhancement. I restored it for this pr. May it can be another pr for this.""",github:GithubAccount:1:17495446,2019-07-26T10:33:56.000+00:00,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,DIFF,github:GithubPrReview:1:267113847,
+github:GithubPrComment:1:315493235,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,11,,github:GithubPullRequest:1:308859272,"""SA2002: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (from `staticcheck`)""",github:GithubAccount:1:42910462,2019-08-20T03:25:26.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,DIFF,github:GithubPrReview:1:276914383,
+github:GithubPrComment:1:315497949,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,12,,github:GithubPullRequest:1:308859272,"""Are these two fields of `MaxBlockingSubmit` and `blockingNum` really necessary? From where I stand, the throttle of your business traffics should be the capacity of pool, if you've set up `nonblocking` as `true`, it returns nil once the amount of all running workers reaches the pool capacity, otherwise, it is blocke [...]
+github:GithubPrComment:1:315498393,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,13,,github:GithubPullRequest:1:308859272,"""This section could be refined as:\r\n```go\r\nif w := p.retrieveWorker(); w == nil {\r\n return ErrPoolBlocked\r\n} else {\r\n w.task <- task\r\n}\r\n```""",github:GithubAccount:1:7496278,2019-08-20T04:02:19.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,DIFF,github:GithubPrReview:1:276920486,
+github:GithubPrComment:1:315498823,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,14,,github:GithubPullRequest:1:308859272,"""The name of `ErrPoolBlocked` is blurry and unable to tell why it is being blocked, I would suggest `ErrPoolOverload` or `ErrPoolOverflow`.""",github:GithubAccount:1:7496278,2019-08-20T04:05:11.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,DIFF,github:GithubPrReview:1:276920486,
+github:GithubPrComment:1:315499067,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,15,,github:GithubPullRequest:1:308859272,"""If this field is necessary, rename it to `MaxBlockingTasks`.""",github:GithubAccount:1:7496278,2019-08-20T04:06:45.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,DIFF,github:GithubPrReview:1:276920486,
+github:GithubPrComment:1:315499281,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_request_review_comments,16,,github:GithubPullRequest:1:308859272,"""I think `Nonblocking` is enough.""",github:GithubAccount:1:7496278,2019-08-20T04:08:21.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,DIFF,github:GithubPrReview:1:276920486,
+github:GithubPrComment:1:407675431,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3162,,github:GithubPullRequest:1:203756736,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/4?src=pr&el=h1) Report\n> Merging [#4](https://codecov.io/gh/panjf2000/ants/pull/4?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/f5b37d0798a8e4c6780a1e08270fa50e979aa1d7?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[! [...]
+github:GithubPrComment:1:407714136,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3163,,github:GithubPullRequest:1:203756736,"""@barryz chinese ， chinese ， chinese ， chinese benchmark chinese 1000w chinese 7w chinese ， chinese 5w chinese ， chinese benchmark chinese ， chinese allocs/op chinese """,github:GithubAccount:1:7496278,2018-07-25T10:49:44.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:407755528,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3164,,github:GithubPullRequest:1:203756736,"""@panjf2000 chinese ， 1000W chinese goroutine chinese ， chinese ， chinese worker chinese ， chinese 。 chinese benchmark chinese \r\n\r\nmaster:\r\n\r\n```\r\ngoos: linux\r\ngoarch: amd64\r\nBenchmarkGoroutineWithFunc-4 1 15079030287 ns/op 723120296 B/op 10176159 allocs/op\r\nPASS\r\nok command-line-arg [...]
+github:GithubPrComment:1:407764945,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3165,,github:GithubPullRequest:1:203756736,"""@barryz chinese ， chinese ， chinese ， chinese ， chinese ， chinese ， chinese """,github:GithubAccount:1:7496278,2018-07-25T14:02:41.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:416794440,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3180,,github:GithubPullRequest:1:211603583,"""@hongli-my chinese ， chinese ？ chinese ？""",github:GithubAccount:1:7496278,2018-08-29T01:39:23.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:416794871,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3181,,github:GithubPullRequest:1:211603583,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/8?src=pr&el=h1) Report\n> Merging [#8](https://codecov.io/gh/panjf2000/ants/pull/8?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/666635c65d8d3bb1223b819325e0bd23c81f2733?src=pr&el=desc) will **decrease** coverage by `1.24%`.\n> The diff coverage is `100 [...]
+github:GithubPrComment:1:416803651,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3182,,github:GithubPullRequest:1:211603583,"""```n := 0\r\n\t\tfor i, w := range idleWorkers {\r\n\t\t\tif currentTime.Sub(w.recycleTime) <= p.expiryDuration {\r\n\t\t\t\tbreak\r\n\t\t\t}\r\n\t\t\tn = i\r\n\t\t\tw.args <- nil\r\n\t\t\tidleWorkers[i] = nil\r\n\t\t}\r\n\t\tn++\r\n\t\tif n >= len(idleWorkers) {\r\n\t\t\tp.workers = idleWorkers[:0]\r\n\t\t} else {\r\n\t\t\tp.workers [...]
+github:GithubPrComment:1:416818094,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3183,,github:GithubPullRequest:1:211603583,"""@hongli-my chinese ， chinese ， chinese ， chinese develop chinese ， chinese ， chinese ， chinese merge""",github:GithubAccount:1:7496278,2018-08-29T04:11:17.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:421884048,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3188,,github:GithubPullRequest:1:211603583,""" chinese worker chinese chan chinese close chinese ， chinese ， chinese """,github:GithubAccount:1:29241786,2018-09-17T03:37:44.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425423544,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3199,,github:GithubPullRequest:1:218939809,"""@liyonglion chinese ， chinese ：\r\n1. chinese pr， chinese ants_test.go chinese import ants chinese ；\r\n2. chinese pool.go chinese ， chinese pool_func.go chinese 。\r\n\r\n chinese pr， chinese ， chinese merge chinese 。""",github:GithubAccount:1:7496278,2018-09-28T12:43:30.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425428914,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3200,,github:GithubPullRequest:1:218939809,""" chinese ， chinese putWorker chinese ， chinese p.cond.Signal() chinese ，p.lock chinese ， chinese \r\n\r\n chinese ， chinese worker chinese ， chinese p.cond.Wait() chinese worker chinese ，len(p.workers) - 1 chinese -1， chinese [...]
+github:GithubPrComment:1:425431081,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3201,,github:GithubPullRequest:1:218939809,""" chinese 。 chinese ， chinese ， chinese 。""",github:GithubAccount:1:12890888,2018-09-28T13:12:08.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425432498,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3202,,github:GithubPullRequest:1:218939809,""" chinese ， chinese 。""",github:GithubAccount:1:7496278,2018-09-28T13:17:44.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425438107,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3203,,github:GithubPullRequest:1:218939809,""" chinese ， chinese 。 chinese ， chinese ，pool chinese 。""",github:GithubAccount:1:12890888,2018-09-28T13:37:48.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425439137,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3204,,github:GithubPullRequest:1:218939809,""" chinese ， chinese 。""",github:GithubAccount:1:12890888,2018-09-28T13:41:20.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425608265,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3205,,github:GithubPullRequest:1:218939809,""" chinese ， chinese 。 chinese """,github:GithubAccount:1:12890888,2018-09-29T02:22:39.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425609411,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3206,,github:GithubPullRequest:1:218939809,"""\r\n chinese ， chinese workers chinese ， chinese Travis CI chinese """,github:GithubAccount:1:7496278,2018-09-29T02:41:56.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425609608,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3207,,github:GithubPullRequest:1:218939809,""" chinese ， chinese 。 chinese """,github:GithubAccount:1:12890888,2018-09-29T02:45:23.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425622339,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3208,,github:GithubPullRequest:1:218939809,""" chinese ：\r\n100w chinese ，5w chinese goroutine\r\n\r\n\r\n\r\n""",github:GithubAccount:1:128908 [...]
+github:GithubPrComment:1:425622437,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3209,,github:GithubPullRequest:1:218939809,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/13?src=pr&el=h1) Report\n> Merging [#13](https://codecov.io/gh/panjf2000/ants/pull/13?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/af376f1b7b59dc488458bcecd4273f0fcde33c55?src=pr&el=desc) will **decrease** coverage by `90.38%`.\n> The diff coverage is [...]
+github:GithubPrComment:1:425623081,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3210,,github:GithubPullRequest:1:218939809,"""@panjf2000 chinese ？""",github:GithubAccount:1:12890888,2018-09-29T07:16:02.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425632550,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3211,,github:GithubPullRequest:1:218939809,""" chinese 。。。""",github:GithubAccount:1:7496278,2018-09-29T09:53:47.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425632613,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3212,,github:GithubPullRequest:1:218939809,""" chinese worker chinese """,github:GithubAccount:1:7496278,2018-09-29T09:54:48.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425632632,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3213,,github:GithubPullRequest:1:218939809,""" chinese 。。。。""",github:GithubAccount:1:12890888,2018-09-29T09:55:07.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425632777,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3214,,github:GithubPullRequest:1:218939809,"""@panjf2000 chinese ， chinese ？""",github:GithubAccount:1:12890888,2018-09-29T09:57:34.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425637776,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3215,,github:GithubPullRequest:1:218939809,"""@liyonglion chinese ， chinese ， chinese ， chinese 。。。""",github:GithubAccount:1:7496278,2018-09-29T11:25:56.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425637938,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3216,,github:GithubPullRequest:1:218939809,""" chinese ， chinese ， chinese import chinese ， chinese merge chinese """,github:GithubAccount:1:7496278,2018-09-29T11:29:28.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:425896318,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3217,,github:GithubPullRequest:1:219363161,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/14?src=pr&el=h1) Report\n> Merging [#14](https://codecov.io/gh/panjf2000/ants/pull/14?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/1b62696050b7030106291980d5220f886b017eff?src=pr&el=desc) will **decrease** coverage by `2.12%`.\n> The diff coverage is ` [...]
+github:GithubPrComment:1:425906970,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3218,,github:GithubPullRequest:1:219363161,"""thanks for your correction and could you also modify the pool_func.go cuz there is also the same useless statement in that file. i will accept this pr after your modification is done, thanks.""",github:GithubAccount:1:7496278,2018-10-01T13:27:04.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:426537013,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3219,,github:GithubPullRequest:1:219936521,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/15?src=pr&el=h1) Report\n> Merging [#15](https://codecov.io/gh/panjf2000/ants/pull/15?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/29730bb70343924a2f56a13a9799611dd1cd27fd?src=pr&el=desc) will **decrease** coverage by `0.84%`.\n> The diff coverage is ` [...]
+github:GithubPrComment:1:426596957,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3220,,github:GithubPullRequest:1:219936521,"""@egonelbre thanks for your interest in this repository and i got some puzzles.\r\nfirstly, i don't understand why you use both the chan struct{} and sync.WaitGroup at once, that seems a bit excessive cuz waitgroup and chan did the same thing.\r\nsecondly, method BenchmarkGoroutine was design to test throughput so it should run withou [...]
+github:GithubPrComment:1:426604764,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3221,,github:GithubPullRequest:1:219936521,"""Hi, semaphore acts as protection to avoid starting too many goroutines at once. `WaitGroup` is used to wait for everything to complete.\r\n\r\n`BenchmarkGoroutine` doesn't wait for all the goroutines to finish, so you are testing goroutine startup speed rather than throughput. It's somewhat unclear what you mean by \""throughput\"" i [...]
+github:GithubPrComment:1:429609579,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3222,,github:GithubPullRequest:1:222703171,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/16?src=pr&el=h1) Report\n> Merging [#16](https://codecov.io/gh/panjf2000/ants/pull/16?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/711dbdb7a222771ce15aaee1bb7b7c6e9731f208?src=pr&el=desc) will **decrease** coverage by `2.03%`.\n> The diff coverage is ` [...]
+github:GithubPrComment:1:433821356,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3223,,github:GithubPullRequest:1:211603583,""" chinese bugfix chinese ？""",github:GithubAccount:1:8923413,2018-10-29T08:10:59.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:434126048,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3224,,github:GithubPullRequest:1:211603583,"""@choleraehyq chinese pr chinese 。""",github:GithubAccount:1:7496278,2018-10-30T00:10:32.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:434126349,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3225,,github:GithubPullRequest:1:211603583,"""@MrDragon1122 chinese channel chinese close chinese ， chinese goroutine chinese channel， chinese 。""",github:GithubAccount:1:7496278,2018-10-30T00:12:13.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:439758381,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3226,,github:GithubPullRequest:1:231840723,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/19?src=pr&el=h1) Report\n> Merging [#19](https://codecov.io/gh/panjf2000/ants/pull/19?src=pr&el=desc) into [develop](https://codecov.io/gh/panjf2000/ants/commit/92acf74bb71c1dc1758c61346c88325284978b3e?src=pr&el=desc) will **increase** coverage by `0.02%`.\n> The diff coverage is [...]
+github:GithubPrComment:1:439758480,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3227,,github:GithubPullRequest:1:231840723,""" chinese \r\n chinese \r\nants.NewPoolWithFunc()\r\n chinese \r\n chinese Resize(0) && Release\r\n chinese ， chinese NewTicker chinese Stop chinese \r\n\r\nflat flat% sum% cum cum%\r\n\r\n 7168.57kB 77.60% 77.60% 7168.57kB 77.60% time.NewTicker\r\n\r\n\r\n\r\n""",github:GithubAccount:1:7931755,2018-11-19T03:06:50.000+00 [...]
+github:GithubPrComment:1:439781607,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3228,,github:GithubPullRequest:1:231840723,""" chinese PR chinese ， chinese PR chinese """,github:GithubAccount:1:7931755,2018-11-19T06:07:43.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:439793352,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3230,,github:GithubPullRequest:1:231840723,""" chinese pr chinese ， chinese failed chinese ， chinese merge， chinese ？ chinese pr chinese 。""",github:GithubAccount:1:7496278,2018-11-19T07:14:58.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:456033956,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3246,,github:GithubPullRequest:1:246250598,"""# [Codecov](https://codecov.io/gh/panjf2000/ants/pull/23?src=pr&el=h1) Report\n> Merging [#23](https://codecov.io/gh/panjf2000/ants/pull/23?src=pr&el=desc) into [master](https://codecov.io/gh/panjf2000/ants/commit/812dd4e01075be3cf97429a43abaf6837908cdcd?src=pr&el=desc) will **decrease** coverage by `1.02%`.\n> The diff coverage is ` [...]
+github:GithubPrComment:1:456071084,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3247,,github:GithubPullRequest:1:246250598,"""@choleraehyq \r\nbuild chinese ， chinese ？""",github:GithubAccount:1:7496278,2019-01-21T13:18:19.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:456261758,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3248,,github:GithubPullRequest:1:246250598,"""@panjf2000 chinese ， chinese PanicHandler chinese ， chinese panic chinese ， chinese worker chinese panic， chinese recover""",github:GithubAccount:1:8923413,2019-01-22T03:45:04.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:456270386,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3249,,github:GithubPullRequest:1:246250598,"""@choleraehyq \r\n chinese ：\r\n1. CI failed chinese TestPanicHandler chinese \r\n\r\n2. chinese Worker chinese recover chinese ， chinese w.pool.decRunning()， chinese panic chinese goroutine chinese ， chinese pool chinese work [...]
+github:GithubPrComment:1:456273052,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3250,,github:GithubPullRequest:1:246250598,"""@panjf2000 thanks， chinese """,github:GithubAccount:1:8923413,2019-01-22T05:10:00.000+00:00,,NORMAL,github:GithubPrReview:1:0,
+github:GithubPrComment:1:456277710,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3251,,github:GithubPullRequest:1:246250598,"""Thanks for your contributions to `ants`!""",github:GithubAccount:1:7496278,2019-01-22T05:41:10.000+00:00,,NORMAL,github:GithubPrReview:1:0,
diff --git a/backend/plugins/github/e2e/snapshot_tables/pull_request_review_comments.csv b/backend/plugins/github/e2e/snapshot_tables/pull_request_review_comments.csv
index 4c833a33d..5ee375800 100644
--- a/backend/plugins/github/e2e/snapshot_tables/pull_request_review_comments.csv
+++ b/backend/plugins/github/e2e/snapshot_tables/pull_request_review_comments.csv
@@ -1,31 +1,31 @@
-id,pull_request_id,body,account_id,created_date,commit_sha,position,type,review_id,status
-github:GithubPrReview:1:277027723,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:05:02.000+00:00,ee1ad289e5af90bd7ee573f2ff1c968e57e3d69b,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:277036116,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T09:19:55.000+00:00,ee1ad289e5af90bd7ee573f2ff1c968e57e3d69b,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:277042368,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:30:46.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:277042525,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:02.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:277042640,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:13.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:277042704,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:20.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:277042799,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:30.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:277048557,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T09:41:40.000+00:00,ee1ad289e5af90bd7ee573f2ff1c968e57e3d69b,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:277049738,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T09:44:27.000+00:00,73aae70ec916a654a7f20ab89eda872b826292ba,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:277062848,github:GithubPullRequest:1:308859272,"Besides, MaxBlockingTasks and Nonblocking are under race risk , please make them goroutine-safe.",github:GithubAccount:1:7496278,2019-08-20T10:08:17.000+00:00,73aae70ec916a654a7f20ab89eda872b826292ba,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:277073714,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T10:31:22.000+00:00,73aae70ec916a654a7f20ab89eda872b826292ba,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:277081346,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T10:48:36.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:286687335,github:GithubPullRequest:1:316337433, chinese comment,github:GithubAccount:1:7496278,2019-09-11T12:07:36.000+00:00,2cef9f56273b2015a0c9a6b96430a6fb695cda94,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:286772978,github:GithubPullRequest:1:316337433,,github:GithubAccount:1:8923413,2019-09-11T13:03:23.000+00:00,2cef9f56273b2015a0c9a6b96430a6fb695cda94,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:286774552,github:GithubPullRequest:1:316337433,,github:GithubAccount:1:8923413,2019-09-11T13:05:57.000+00:00,2cef9f56273b2015a0c9a6b96430a6fb695cda94,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:298229495,github:GithubPullRequest:1:325179595, chinese review chinese PR chinese ， chinese comments， chinese 。,github:GithubAccount:1:7496278,2019-10-07T16:56:26.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,0,REVIEW,,CHANGES_REQUESTED
-github:GithubPrReview:1:298484051,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T00:45:44.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:298484184,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T00:46:21.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:298499211,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T01:59:39.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:298503749,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:7496278,2019-10-08T02:22:38.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:298544685,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:7496278,2019-10-08T05:53:30.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:298546417,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:7496278,2019-10-08T06:00:53.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:298546957,github:GithubPullRequest:1:325179595, chinese comments， chinese ~~,github:GithubAccount:1:7496278,2019-10-08T06:07:20.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,0,REVIEW,,CHANGES_REQUESTED
-github:GithubPrReview:1:298547873,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T06:06:51.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:298549409,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:7496278,2019-10-08T06:13:03.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:298549661,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:7496278,2019-10-08T06:14:00.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:298789411,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T14:06:55.000+00:00,2516ada077dcec8ee338a5409d74fec35b6c8d98,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:298791860,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T14:10:13.000+00:00,2516ada077dcec8ee338a5409d74fec35b6c8d98,0,REVIEW,,COMMENTED
-github:GithubPrReview:1:299362850,github:GithubPullRequest:1:325179595, chinese 。,github:GithubAccount:1:7496278,2019-10-09T12:58:59.000+00:00,460fea75691aa2dee5d0737fa07e442db465b6b0,0,REVIEW,,CHANGES_REQUESTED
-github:GithubPrReview:1:299446893,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-09T14:18:28.000+00:00,460fea75691aa2dee5d0737fa07e442db465b6b0,0,REVIEW,,COMMENTED
+id,pull_request_id,body,account_id,created_date,commit_sha,type,review_id,status
+github:GithubPrReview:1:277027723,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:05:02.000+00:00,ee1ad289e5af90bd7ee573f2ff1c968e57e3d69b,REVIEW,,COMMENTED
+github:GithubPrReview:1:277036116,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T09:19:55.000+00:00,ee1ad289e5af90bd7ee573f2ff1c968e57e3d69b,REVIEW,,COMMENTED
+github:GithubPrReview:1:277042368,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:30:46.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,REVIEW,,COMMENTED
+github:GithubPrReview:1:277042525,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:02.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,REVIEW,,COMMENTED
+github:GithubPrReview:1:277042640,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:13.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,REVIEW,,COMMENTED
+github:GithubPrReview:1:277042704,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:20.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,REVIEW,,COMMENTED
+github:GithubPrReview:1:277042799,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:30.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,REVIEW,,COMMENTED
+github:GithubPrReview:1:277048557,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T09:41:40.000+00:00,ee1ad289e5af90bd7ee573f2ff1c968e57e3d69b,REVIEW,,COMMENTED
+github:GithubPrReview:1:277049738,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T09:44:27.000+00:00,73aae70ec916a654a7f20ab89eda872b826292ba,REVIEW,,COMMENTED
+github:GithubPrReview:1:277062848,github:GithubPullRequest:1:308859272,"Besides, MaxBlockingTasks and Nonblocking are under race risk , please make them goroutine-safe.",github:GithubAccount:1:7496278,2019-08-20T10:08:17.000+00:00,73aae70ec916a654a7f20ab89eda872b826292ba,REVIEW,,COMMENTED
+github:GithubPrReview:1:277073714,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T10:31:22.000+00:00,73aae70ec916a654a7f20ab89eda872b826292ba,REVIEW,,COMMENTED
+github:GithubPrReview:1:277081346,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T10:48:36.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,REVIEW,,COMMENTED
+github:GithubPrReview:1:286687335,github:GithubPullRequest:1:316337433," chinese comment",github:GithubAccount:1:7496278,2019-09-11T12:07:36.000+00:00,2cef9f56273b2015a0c9a6b96430a6fb695cda94,REVIEW,,COMMENTED
+github:GithubPrReview:1:286772978,github:GithubPullRequest:1:316337433,,github:GithubAccount:1:8923413,2019-09-11T13:03:23.000+00:00,2cef9f56273b2015a0c9a6b96430a6fb695cda94,REVIEW,,COMMENTED
+github:GithubPrReview:1:286774552,github:GithubPullRequest:1:316337433,,github:GithubAccount:1:8923413,2019-09-11T13:05:57.000+00:00,2cef9f56273b2015a0c9a6b96430a6fb695cda94,REVIEW,,COMMENTED
+github:GithubPrReview:1:298229495,github:GithubPullRequest:1:325179595," chinese review chinese PR chinese ， chinese comments， chinese 。",github:GithubAccount:1:7496278,2019-10-07T16:56:26.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,REVIEW,,CHANGES_REQUESTED
+github:GithubPrReview:1:298484051,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T00:45:44.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,REVIEW,,COMMENTED
+github:GithubPrReview:1:298484184,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T00:46:21.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,REVIEW,,COMMENTED
+github:GithubPrReview:1:298499211,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T01:59:39.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,REVIEW,,COMMENTED
+github:GithubPrReview:1:298503749,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:7496278,2019-10-08T02:22:38.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,REVIEW,,COMMENTED
+github:GithubPrReview:1:298544685,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:7496278,2019-10-08T05:53:30.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,REVIEW,,COMMENTED
+github:GithubPrReview:1:298546417,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:7496278,2019-10-08T06:00:53.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,REVIEW,,COMMENTED
+github:GithubPrReview:1:298546957,github:GithubPullRequest:1:325179595," chinese comments， chinese ~~",github:GithubAccount:1:7496278,2019-10-08T06:07:20.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,REVIEW,,CHANGES_REQUESTED
+github:GithubPrReview:1:298547873,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T06:06:51.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,REVIEW,,COMMENTED
+github:GithubPrReview:1:298549409,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:7496278,2019-10-08T06:13:03.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,REVIEW,,COMMENTED
+github:GithubPrReview:1:298549661,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:7496278,2019-10-08T06:14:00.000+00:00,2950e919e72eb230b2b12f797f379ca6f04fe80c,REVIEW,,COMMENTED
+github:GithubPrReview:1:298789411,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T14:06:55.000+00:00,2516ada077dcec8ee338a5409d74fec35b6c8d98,REVIEW,,COMMENTED
+github:GithubPrReview:1:298791860,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-08T14:10:13.000+00:00,2516ada077dcec8ee338a5409d74fec35b6c8d98,REVIEW,,COMMENTED
+github:GithubPrReview:1:299362850,github:GithubPullRequest:1:325179595," chinese 。",github:GithubAccount:1:7496278,2019-10-09T12:58:59.000+00:00,460fea75691aa2dee5d0737fa07e442db465b6b0,REVIEW,,CHANGES_REQUESTED
+github:GithubPrReview:1:299446893,github:GithubPullRequest:1:325179595,,github:GithubAccount:1:2813260,2019-10-09T14:18:28.000+00:00,460fea75691aa2dee5d0737fa07e442db465b6b0,REVIEW,,COMMENTED
diff --git a/backend/plugins/gitlab/e2e/mr_notes_test.go b/backend/plugins/gitlab/e2e/mr_notes_test.go
index 13555a1c5..6f4d02185 100644
--- a/backend/plugins/gitlab/e2e/mr_notes_test.go
+++ b/backend/plugins/gitlab/e2e/mr_notes_test.go
@@ -131,7 +131,6 @@ func TestGitlabMrNoteDataFlow(t *testing.T) {
"account_id",
"created_date",
"commit_sha",
- "position",
),
)
}
diff --git a/backend/plugins/gitlab/e2e/snapshot_tables/pull_request_comments.csv b/backend/plugins/gitlab/e2e/snapshot_tables/pull_request_comments.csv
index 932ba5bf2..de8f8729c 100644
--- a/backend/plugins/gitlab/e2e/snapshot_tables/pull_request_comments.csv
+++ b/backend/plugins/gitlab/e2e/snapshot_tables/pull_request_comments.csv
@@ -1,11 +1,11 @@
-id,pull_request_id,body,account_id,created_date,commit_sha,position,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
-gitlab:GitlabMrComment:1:135100359,gitlab:GitlabMergeRequest:1:1149942101,approved this merge request,gitlab:GitlabAccount:1:3393147,2019-01-25T16:46:23.996+00:00,,0,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,71,
-gitlab:GitlabMrComment:1:135223089,gitlab:GitlabMergeRequest:1:135772105,approved this merge request,gitlab:GitlabAccount:1:3393147,2019-01-26T11:41:34.158+00:00,,0,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,126,
-gitlab:GitlabMrComment:1:135848627,gitlab:GitlabMergeRequest:1:15869219,approved this merge request,gitlab:GitlabAccount:1:2436773,2019-01-29T00:40:37.158+00:00,,0,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,169,
-gitlab:GitlabMrComment:1:135848646,gitlab:GitlabMergeRequest:1:15869219,unapproved this merge request,gitlab:GitlabAccount:1:2436773,2019-01-29T00:40:45.520+00:00,,0,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,170,
-gitlab:GitlabMrComment:1:135848654,gitlab:GitlabMergeRequest:1:15869219,approved this merge request,gitlab:GitlabAccount:1:2436773,2019-01-29T00:40:47.455+00:00,,0,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,171,
-gitlab:GitlabMrComment:1:137424744,gitlab:GitlabMergeRequest:1:145032495,approved this merge request,gitlab:GitlabAccount:1:3014346,2019-02-01T11:43:54.686+00:00,,0,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,151,
-gitlab:GitlabMrComment:1:186439132,gitlab:GitlabMergeRequest:1:32348491,"@tayloramurphy Once this is merged, let's make this a release version?",gitlab:GitlabAccount:1:2295562,2019-06-28T10:56:46.646+00:00,,0,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,7,
-gitlab:GitlabMrComment:1:208061122,gitlab:GitlabMergeRequest:1:35064956,@mg12 This looks good to me. Want me to merge?,gitlab:GitlabAccount:1:2295562,2019-08-26T12:14:39.003+00:00,,0,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,12,
-gitlab:GitlabMrComment:1:208092969,gitlab:GitlabMergeRequest:1:35064956,@emilie Let's do it!,gitlab:GitlabAccount:1:3871284,2019-08-26T13:17:51.707+00:00,,0,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,13,
-gitlab:GitlabMrComment:1:208121781,gitlab:GitlabMergeRequest:1:35064956,Merged! Thanks for your contribution @mg12!,gitlab:GitlabAccount:1:2295562,2019-08-26T14:15:40.464+00:00,,0,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,17,
+id,pull_request_id,body,account_id,created_date,commit_sha,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
+gitlab:GitlabMrComment:1:135100359,gitlab:GitlabMergeRequest:1:1149942101,approved this merge request,gitlab:GitlabAccount:1:3393147,2019-01-25T16:46:23.996+00:00,,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,71,
+gitlab:GitlabMrComment:1:135223089,gitlab:GitlabMergeRequest:1:135772105,approved this merge request,gitlab:GitlabAccount:1:3393147,2019-01-26T11:41:34.158+00:00,,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,126,
+gitlab:GitlabMrComment:1:135848627,gitlab:GitlabMergeRequest:1:15869219,approved this merge request,gitlab:GitlabAccount:1:2436773,2019-01-29T00:40:37.158+00:00,,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,169,
+gitlab:GitlabMrComment:1:135848646,gitlab:GitlabMergeRequest:1:15869219,unapproved this merge request,gitlab:GitlabAccount:1:2436773,2019-01-29T00:40:45.520+00:00,,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,170,
+gitlab:GitlabMrComment:1:135848654,gitlab:GitlabMergeRequest:1:15869219,approved this merge request,gitlab:GitlabAccount:1:2436773,2019-01-29T00:40:47.455+00:00,,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,171,
+gitlab:GitlabMrComment:1:137424744,gitlab:GitlabMergeRequest:1:145032495,approved this merge request,gitlab:GitlabAccount:1:3014346,2019-02-01T11:43:54.686+00:00,,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,151,
+gitlab:GitlabMrComment:1:186439132,gitlab:GitlabMergeRequest:1:32348491,"@tayloramurphy Once this is merged, let's make this a release version?",gitlab:GitlabAccount:1:2295562,2019-06-28T10:56:46.646+00:00,,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,7,
+gitlab:GitlabMrComment:1:208061122,gitlab:GitlabMergeRequest:1:35064956,@mg12 This looks good to me. Want me to merge?,gitlab:GitlabAccount:1:2295562,2019-08-26T12:14:39.003+00:00,,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,12,
+gitlab:GitlabMrComment:1:208092969,gitlab:GitlabMergeRequest:1:35064956,@emilie Let's do it!,gitlab:GitlabAccount:1:3871284,2019-08-26T13:17:51.707+00:00,,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,13,
+gitlab:GitlabMrComment:1:208121781,gitlab:GitlabMergeRequest:1:35064956,Merged! Thanks for your contribution @mg12!,gitlab:GitlabAccount:1:2295562,2019-08-26T14:15:40.464+00:00,,"{""ConnectionId"":1,""ProjectId"":12345678}",_raw_gitlab_api_merge_request_notes,17,
diff --git a/backend/python/pydevlake/pydevlake/domain_layer/code.py b/backend/python/pydevlake/pydevlake/domain_layer/code.py
index 0bc082125..cffe7f502 100644
--- a/backend/python/pydevlake/pydevlake/domain_layer/code.py
+++ b/backend/python/pydevlake/pydevlake/domain_layer/code.py
@@ -69,7 +69,6 @@ class PullRequestComment(DomainModel, table=True):
account_id: str
created_date: datetime
commit_sha: str
- position: int
type: str
review_id: str
status: str