You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Andras Salamon <an...@melda.info> on 2018/11/23 12:50:34 UTC
Review Request 69437: OOZIE-3384 - [tests]
TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69437/
-----------------------------------------------------------
Review request for oozie, András Piros and Kinga Marton.
Repository: oozie-git
Description
-------
OOZIE-3384 - [tests] TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
Diffs
-----
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java 5c06ae554
Diff: https://reviews.apache.org/r/69437/diff/1/
Testing
-------
Executed 50 times using grind:
50/50 tests complete
Thanks,
Andras Salamon
Re: Review Request 69437: OOZIE-3384 - [tests]
TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
Posted by Andras Salamon <an...@melda.info>.
> On Nov. 26, 2018, 9:10 a.m., Kinga Marton wrote:
> > core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java
> > Lines 214 (patched)
> > <https://reviews.apache.org/r/69437/diff/1/?file=2110235#file2110235line217>
> >
> > Wouldn't be better to return an empty(Collections.emptyList()) list instead of null in order to avoid NPEs or null checks?
Unfortunately command.call() can also return null, so I cannot eliminate the null checks. Reorganized the checks a bit to make it more logical.
- Andras
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69437/#review210853
-----------------------------------------------------------
On Nov. 26, 2018, 11:17 a.m., Andras Salamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69437/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2018, 11:17 a.m.)
>
>
> Review request for oozie, András Piros and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3384 - [tests] TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
>
>
> Diffs
> -----
>
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java 5c06ae554
>
>
> Diff: https://reviews.apache.org/r/69437/diff/2/
>
>
> Testing
> -------
>
> Executed 50 times using grind:
>
> 50/50 tests complete
>
>
> Thanks,
>
> Andras Salamon
>
>
Re: Review Request 69437: OOZIE-3384 - [tests]
TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69437/#review210853
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java
Lines 150-151 (original), 150-151 (patched)
<https://reviews.apache.org/r/69437/#comment295612>
Please remove commented lines
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java
Line 171 (original), 172 (patched)
<https://reviews.apache.org/r/69437/#comment295614>
Possible NPE, if retriesList==null.
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java
Lines 214 (patched)
<https://reviews.apache.org/r/69437/#comment295613>
Wouldn't be better to return an empty(Collections.emptyList()) list instead of null in order to avoid NPEs or null checks?
- Kinga Marton
On Nov. 23, 2018, 12:50 p.m., Andras Salamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69437/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2018, 12:50 p.m.)
>
>
> Review request for oozie, András Piros and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3384 - [tests] TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
>
>
> Diffs
> -----
>
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java 5c06ae554
>
>
> Diff: https://reviews.apache.org/r/69437/diff/1/
>
>
> Testing
> -------
>
> Executed 50 times using grind:
>
> 50/50 tests complete
>
>
> Thanks,
>
> Andras Salamon
>
>
Re: Review Request 69437: OOZIE-3384 - [tests]
TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
> On Nov. 28, 2018, 8:28 a.m., Kinga Marton wrote:
> > core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java
> > Lines 22 (patched)
> > <https://reviews.apache.org/r/69437/diff/2/?file=2110373#file2110373line22>
> >
> > nit: unused iport
*import
- Kinga
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69437/#review210919
-----------------------------------------------------------
On Nov. 26, 2018, 11:17 a.m., Andras Salamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69437/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2018, 11:17 a.m.)
>
>
> Review request for oozie, András Piros and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3384 - [tests] TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
>
>
> Diffs
> -----
>
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java 5c06ae554
>
>
> Diff: https://reviews.apache.org/r/69437/diff/2/
>
>
> Testing
> -------
>
> Executed 50 times using grind:
>
> 50/50 tests complete
>
>
> Thanks,
>
> Andras Salamon
>
>
Re: Review Request 69437: OOZIE-3384 - [tests]
TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69437/#review210919
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java
Lines 22 (patched)
<https://reviews.apache.org/r/69437/#comment295745>
nit: unused iport
- Kinga Marton
On Nov. 26, 2018, 11:17 a.m., Andras Salamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69437/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2018, 11:17 a.m.)
>
>
> Review request for oozie, András Piros and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3384 - [tests] TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
>
>
> Diffs
> -----
>
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java 5c06ae554
>
>
> Diff: https://reviews.apache.org/r/69437/diff/2/
>
>
> Testing
> -------
>
> Executed 50 times using grind:
>
> 50/50 tests complete
>
>
> Thanks,
>
> Andras Salamon
>
>
Re: Review Request 69437: OOZIE-3384 - [tests]
TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69437/#review210923
-----------------------------------------------------------
Ship it!
Ship It!
- Kinga Marton
On Nov. 28, 2018, 9:03 a.m., Andras Salamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69437/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2018, 9:03 a.m.)
>
>
> Review request for oozie, András Piros and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3384 - [tests] TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
>
>
> Diffs
> -----
>
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java 5c06ae554
>
>
> Diff: https://reviews.apache.org/r/69437/diff/3/
>
>
> Testing
> -------
>
> Executed 50 times using grind:
>
> 50/50 tests complete
>
>
> Thanks,
>
> Andras Salamon
>
>
Re: Review Request 69437: OOZIE-3384 - [tests]
TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
Posted by Andras Salamon <an...@melda.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69437/
-----------------------------------------------------------
(Updated Nov. 28, 2018, 9:03 a.m.)
Review request for oozie, András Piros and Kinga Marton.
Changes
-------
Removing unused import
Repository: oozie-git
Description
-------
OOZIE-3384 - [tests] TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
Diffs (updated)
-----
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java 5c06ae554
Diff: https://reviews.apache.org/r/69437/diff/3/
Changes: https://reviews.apache.org/r/69437/diff/2-3/
Testing
-------
Executed 50 times using grind:
50/50 tests complete
Thanks,
Andras Salamon
Re: Review Request 69437: OOZIE-3384 - [tests]
TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
Posted by Andras Salamon <an...@melda.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69437/
-----------------------------------------------------------
(Updated Nov. 26, 2018, 11:17 a.m.)
Review request for oozie, András Piros and Kinga Marton.
Changes
-------
Addressing review suggestions.
Repository: oozie-git
Description
-------
OOZIE-3384 - [tests] TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky
Diffs (updated)
-----
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java 5c06ae554
Diff: https://reviews.apache.org/r/69437/diff/2/
Changes: https://reviews.apache.org/r/69437/diff/1-2/
Testing
-------
Executed 50 times using grind:
50/50 tests complete
Thanks,
Andras Salamon