You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by zhtisi <gi...@git.apache.org> on 2018/01/03 15:55:31 UTC

[GitHub] bigtop pull request #334: Update bigtop-detect-javahome for variable typo

GitHub user zhtisi opened a pull request:

    https://github.com/apache/bigtop/pull/334

    Update bigtop-detect-javahome for variable typo

    In line 56 and line 60, $OPENJAVA8_HOME_CANDIDATES can only be empty because there was a typo in defining variable $OPENJAVA8_HOME__CANDIDATES in line 34.   There are two _ between "HOME" and "CANDIDATES" in line 34. But There is only one _  between "HOME" and "CANDIDATES" when using the variable in line 56 and line 60. For other variable using one _ as the separator instead of two _ , I suggest changing variable $OPENJAVA8_HOME__CANDIDATES(with two _ between "HOME" and "CANDIDATES") in line 34 to $OPENJAVA8_HOME_CANDIDATES(with only one _ between "HOME" and "CANDIDATES")

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhtisi/bigtop patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bigtop/pull/334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #334
    
----
commit b6ae10bb3a6b5d0580208e51bff1d6fdb5f605c1
Author: zhtisi <53...@...>
Date:   2018-01-03T15:43:05Z

    Update bigtop-detect-javahome for variable typo
    
    In line 56 and line 60, ${OPENJAVA8_HOME_CANDIDATES} can only be empty because there was a typo in defining variable OPENJAVA8_HOME__CANDIDATES in line 34.   There are two '_' between "HOME" and "CANDIDATES" in line 34. But There is only one '_'  between "HOME" and "CANDIDATES" when using the variable in line 56 and line 60. For other variable using one '_' as the separator instead of two '_', I suggest changing variable $OPENJAVA8_HOME__CANDIDATES(with two '_' between "HOME" and "CANDIDATES") in line 34 to $OPENJAVA8_HOME_CANDIDATES(with only one '_' between "HOME" and "CANDIDATES")

----


---

[GitHub] bigtop pull request #334: Update bigtop-detect-javahome for variable typo

Posted by zhtisi <gi...@git.apache.org>.
Github user zhtisi closed the pull request at:

    https://github.com/apache/bigtop/pull/334


---