You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by anilkumar gingade <ag...@pivotal.io> on 2016/05/21 00:57:02 UTC
Review Request 47686: GEODE-11: Added changes to Lucene AEQ,
to propagate destroy events due to eviction and expiration (by setting the
flag ignoreEvictionAndExpiration()).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47686/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).
Added test to verify, the lucene index gets updated with expiration destroy operation.
Also added support to specify wild-char as leading wild character with Lucene Query.
Diffs
-----
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java d22ca4a196df3b1a457b56c92da694bdbf792cc2
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java 1e2b63d0fc5c7fad79063199c473bbd9d4e6fd00
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java 07780ca06a297851c8ff4cb498a09f726a0785d5
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 15f5747231097df5223d97bb49110229efe6a824
Diff: https://reviews.apache.org/r/47686/diff/
Testing
-------
Thanks,
anilkumar gingade
Re: Review Request 47686: GEODE-11: Added changes to Lucene AEQ,
to propagate destroy events due to eviction and expiration (by setting the
flag ignoreEvictionAndExpiration()).
Posted by anilkumar gingade <ag...@pivotal.io>.
> On May 24, 2016, 9:44 p.m., Dan Smith wrote:
> > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java, line 70
> > <https://reviews.apache.org/r/47686/diff/2/?file=1392007#file1392007line70>
> >
> > The javadocs for setAllowLeadingWildercard say this: "Note that this can produce very slow queries on big indexes."
> >
> > Is this something we really want to enable?
This is a very useful option to fetch all the data from the lucene index...In database its common to use "select all"...It could be expensive based on the index data size, as this is similar to table scan....I could not find any place saying this will impact other queries...If you don't see need of this, I am fine with removing this...
- anilkumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47686/#review134641
-----------------------------------------------------------
On May 24, 2016, 12:05 a.m., anilkumar gingade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47686/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 12:05 a.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).
> Added test to verify, the lucene index gets updated with expiration destroy operation.
> Also added support to specify wild-char as leading wild character with Lucene Query.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java d22ca4a196df3b1a457b56c92da694bdbf792cc2
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java 1e2b63d0fc5c7fad79063199c473bbd9d4e6fd00
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java 07780ca06a297851c8ff4cb498a09f726a0785d5
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 15f5747231097df5223d97bb49110229efe6a824
>
> Diff: https://reviews.apache.org/r/47686/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> anilkumar gingade
>
>
Re: Review Request 47686: GEODE-11: Added changes to Lucene AEQ,
to propagate destroy events due to eviction and expiration (by setting the
flag ignoreEvictionAndExpiration()).
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47686/#review134641
-----------------------------------------------------------
Fix it, then Ship it!
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java (line 70)
<https://reviews.apache.org/r/47686/#comment199488>
The javadocs for setAllowLeadingWildercard say this: "Note that this can produce very slow queries on big indexes."
Is this something we really want to enable?
- Dan Smith
On May 24, 2016, 12:05 a.m., anilkumar gingade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47686/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 12:05 a.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).
> Added test to verify, the lucene index gets updated with expiration destroy operation.
> Also added support to specify wild-char as leading wild character with Lucene Query.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java d22ca4a196df3b1a457b56c92da694bdbf792cc2
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java 1e2b63d0fc5c7fad79063199c473bbd9d4e6fd00
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java 07780ca06a297851c8ff4cb498a09f726a0785d5
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 15f5747231097df5223d97bb49110229efe6a824
>
> Diff: https://reviews.apache.org/r/47686/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> anilkumar gingade
>
>
Re: Review Request 47686: GEODE-11: Added changes to Lucene AEQ,
to propagate destroy events due to eviction and expiration (by setting the
flag ignoreEvictionAndExpiration()).
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47686/
-----------------------------------------------------------
(Updated May 24, 2016, 12:05 a.m.)
Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
Changes
-------
Revoved the commented expiration action in the test.
Repository: geode
Description
-------
GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).
Added test to verify, the lucene index gets updated with expiration destroy operation.
Also added support to specify wild-char as leading wild character with Lucene Query.
Diffs (updated)
-----
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java d22ca4a196df3b1a457b56c92da694bdbf792cc2
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java 1e2b63d0fc5c7fad79063199c473bbd9d4e6fd00
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java 07780ca06a297851c8ff4cb498a09f726a0785d5
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 15f5747231097df5223d97bb49110229efe6a824
Diff: https://reviews.apache.org/r/47686/diff/
Testing
-------
Thanks,
anilkumar gingade
Re: Review Request 47686: GEODE-11: Added changes to Lucene AEQ,
to propagate destroy events due to eviction and expiration (by setting the
flag ignoreEvictionAndExpiration()).
Posted by anilkumar gingade <ag...@pivotal.io>.
> On May 23, 2016, 3:54 p.m., Jason Huynh wrote:
> > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java, line 120
> > <https://reviews.apache.org/r/47686/diff/1/?file=1390286#file1390286line120>
> >
> > is this supposed to be commented out?
Good catch...Its not supposed to be commented...Uploaded the latest changes for review.
- anilkumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47686/#review134367
-----------------------------------------------------------
On May 21, 2016, 12:57 a.m., anilkumar gingade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47686/
> -----------------------------------------------------------
>
> (Updated May 21, 2016, 12:57 a.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).
> Added test to verify, the lucene index gets updated with expiration destroy operation.
> Also added support to specify wild-char as leading wild character with Lucene Query.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java d22ca4a196df3b1a457b56c92da694bdbf792cc2
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java 1e2b63d0fc5c7fad79063199c473bbd9d4e6fd00
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java 07780ca06a297851c8ff4cb498a09f726a0785d5
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 15f5747231097df5223d97bb49110229efe6a824
>
> Diff: https://reviews.apache.org/r/47686/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> anilkumar gingade
>
>
Re: Review Request 47686: GEODE-11: Added changes to Lucene AEQ,
to propagate destroy events due to eviction and expiration (by setting the
flag ignoreEvictionAndExpiration()).
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47686/#review134367
-----------------------------------------------------------
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java (line 120)
<https://reviews.apache.org/r/47686/#comment199153>
is this supposed to be commented out?
- Jason Huynh
On May 21, 2016, 12:57 a.m., anilkumar gingade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47686/
> -----------------------------------------------------------
>
> (Updated May 21, 2016, 12:57 a.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).
> Added test to verify, the lucene index gets updated with expiration destroy operation.
> Also added support to specify wild-char as leading wild character with Lucene Query.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java d22ca4a196df3b1a457b56c92da694bdbf792cc2
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java 1e2b63d0fc5c7fad79063199c473bbd9d4e6fd00
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java 07780ca06a297851c8ff4cb498a09f726a0785d5
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 15f5747231097df5223d97bb49110229efe6a824
>
> Diff: https://reviews.apache.org/r/47686/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> anilkumar gingade
>
>