You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2022/03/17 23:03:40 UTC
[kudu] 01/02: [write_throttling-itest] relax threshold to avoid flakiness
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit df65b3a3d04115fc38bdb739207123816999557d
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Mon Mar 14 17:13:16 2022 -0700
[write_throttling-itest] relax threshold to avoid flakiness
I saw a failure [1] of the WriteThrottlingTest.ThrottleWriteRpcPerSec
test scenario during gerrit pre-commit tests for [2]:
src/kudu/integration-tests/write_throttling-itest.cc:107
Expected: (qps) <= (TARGET_QPS * 1.2f), actual: 121.467 vs 120
This patch relaxes the threshold for the target QPS: 1.2 --> 1.25.
FWIW, the token-based accounting could be affected by scheduler
anomalies and bursts in request rates, so there isn't anything
unexpected here.
[1] http://jenkins.kudu.apache.org/job/kudu-gerrit/25223/
[2] http://gerrit.cloudera.org:8080/18318
Change-Id: Iad3335595b02e66cdc588755b8f53c77442d5736
Reviewed-on: http://gerrit.cloudera.org:8080/18320
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
src/kudu/integration-tests/write_throttling-itest.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kudu/integration-tests/write_throttling-itest.cc b/src/kudu/integration-tests/write_throttling-itest.cc
index 8db7a2a..839db17 100644
--- a/src/kudu/integration-tests/write_throttling-itest.cc
+++ b/src/kudu/integration-tests/write_throttling-itest.cc
@@ -104,7 +104,7 @@ TEST_F(WriteThrottlingTest, ThrottleWriteRpcPerSec) {
MonoDelta delta = end - begin;
double qps = TARGET_QPS / delta.ToSeconds();
LOG(INFO) << "Iteration " << t << " qps: " << qps;
- ASSERT_LE(qps, TARGET_QPS * 1.2f);
+ ASSERT_LE(qps, TARGET_QPS * 1.25f);
}
}