You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/24 20:53:36 UTC
[GitHub] [hudi] xushiyan opened a new pull request #1873: [HUDI-995] Move TestRawTripPayload and HoodieTestDataGenerator to hudi-common
xushiyan opened a new pull request #1873:
URL: https://github.com/apache/hudi/pull/1873
To allow wider access to these classes
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #1873: [HUDI-995] Move TestRawTripPayload and HoodieTestDataGenerator to hudi-common
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #1873:
URL: https://github.com/apache/hudi/pull/1873#discussion_r460283968
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/RawTripTestPayload.java
##########
@@ -141,59 +138,4 @@ private String unCompressData(byte[] data) throws IOException {
}
}
- /**
- * A custom {@link WriteStatus} that merges passed metadata key value map to {@code WriteStatus.markSuccess()} and
- * {@code WriteStatus.markFailure()}.
- */
- public static class MetadataMergeWriteStatus extends WriteStatus {
Review comment:
move this to a separate class; it needs to stay in hudi-client
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #1873: [HUDI-995] Move TestRawTripPayload and HoodieTestDataGenerator to hudi-common
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #1873:
URL: https://github.com/apache/hudi/pull/1873#discussion_r460451609
##########
File path: hudi-utilities/src/test/java/org/apache/hudi/common/fs/inline/TestParquetInLining.java
##########
@@ -48,8 +47,7 @@
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
/**
- * Tests {@link InLineFileSystem} with Parquet writer and reader. hudi-common can't access HoodieTestDataGenerator.
- * Hence keeping this test in hudi-utilities.
+ * Tests for {@link InLineFileSystem} with Parquet writer and reader.
*/
Review comment:
An example of benefit from the class move
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #1873: [HUDI-995] Move TestRawTripPayload and HoodieTestDataGenerator to hudi-common
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #1873:
URL: https://github.com/apache/hudi/pull/1873#discussion_r460283968
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/RawTripTestPayload.java
##########
@@ -141,59 +138,4 @@ private String unCompressData(byte[] data) throws IOException {
}
}
- /**
- * A custom {@link WriteStatus} that merges passed metadata key value map to {@code WriteStatus.markSuccess()} and
- * {@code WriteStatus.markFailure()}.
- */
- public static class MetadataMergeWriteStatus extends WriteStatus {
Review comment:
moved this to a separate class file; it needs to stay in hudi-client
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua merged pull request #1873: [HUDI-995] Move TestRawTripPayload and HoodieTestDataGenerator to hudi-common
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #1873:
URL: https://github.com/apache/hudi/pull/1873
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #1873: [HUDI-995] Move TestRawTripPayload and HoodieTestDataGenerator to hudi-common
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1873:
URL: https://github.com/apache/hudi/pull/1873#issuecomment-663927747
> @yanghua would you be able to take a pass on this change please? thanks
Yes, I'd like to review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #1873: [HUDI-995] Move TestRawTripPayload and HoodieTestDataGenerator to hudi-common
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1873:
URL: https://github.com/apache/hudi/pull/1873#issuecomment-663911960
@yanghua would you be able to take a pass on this change please? thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org