You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/05 22:16:49 UTC

[GitHub] [maven] boris-unckel opened a new pull request #426: [MNG-7068] - Manage Google Guava dependency independent

boris-unckel opened a new pull request #426:
URL: https://github.com/apache/maven/pull/426


   Fixes [MNG-7068](https://issues.apache.org/jira/browse/MNG-7068)
   
   The proposal is first to add com.google.guava:guava to the excludes of guice. Second guava and failureaccess shall be added as direct dependencies.
   
   This has two advantages: Downstream projects only get the needed dependencies and the version of guava can be independently set.
   
   The runtime dependencies for Guava are explained in the last section of the [README](https://github.com/google/guava/tree/v30.1) "Important Warnings" #3
   
    - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically. (org.apache.maven.xml.Factories checkstyle fail. Not related to this PR)
    - [X] You have run the [Core IT][core-its] successfully.
   
   ICLA signed and send to the secretary.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #426: [MNG-7068] - Manage Google Guava dependency independent

Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #426:
URL: https://github.com/apache/maven/pull/426#issuecomment-771761284


   Merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] boris-unckel commented on pull request #426: [MNG-7068] - Manage Google Guava dependency independent

Posted by GitBox <gi...@apache.org>.
boris-unckel commented on pull request #426:
URL: https://github.com/apache/maven/pull/426#issuecomment-754938261


   @michael-o This is the corresponding PR to [https://github.com/apache/maven-resolver/pull/86](https://github.com/apache/maven-resolver/pull/86) Unfortunately a unrelated checkstyle fails. Could you please check and give an advise? Thanks in advance.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] michael-o closed pull request #426: [MNG-7068] - Manage Google Guava dependency independent

Posted by GitBox <gi...@apache.org>.
michael-o closed pull request #426:
URL: https://github.com/apache/maven/pull/426


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] michael-o closed pull request #426: [MNG-7068] - Manage Google Guava dependency independent

Posted by GitBox <gi...@apache.org>.
michael-o closed pull request #426:
URL: https://github.com/apache/maven/pull/426


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #426: [MNG-7068] - Manage Google Guava dependency independent

Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #426:
URL: https://github.com/apache/maven/pull/426#issuecomment-771761284


   Merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org