You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/05/14 15:11:36 UTC

[GitHub] flink pull request #6012: [FLINK-9361] [sql-client] Fix refresh interval in ...

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/6012

    [FLINK-9361] [sql-client] Fix refresh interval in changelog mode

    ## What is the purpose of the change
    
    This PR removes a InterruptedIOException when changing the refresh interval of the SQL Client CLI in changelog mode.
    
    
    ## Brief change log
    
    - Do not use interrupts but a `wait`/`notify` pattern.
    - Deselected row on refresh in changelog mode.
    
    ## Verifying this change
    
    Manually verified.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-9361

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6012.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6012
    
----
commit 7e975502ef9b89a47b019315d7019fd110af68db
Author: Timo Walther <tw...@...>
Date:   2018-05-14T14:48:12Z

    [FLINK-9361] [sql-client] Fix refresh interval in changelog mode

----


---

[GitHub] flink issue #6012: [FLINK-9361] [sql-client] Fix refresh interval in changel...

Posted by twalthr <gi...@git.apache.org>.

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/6012
  
    Thank you @fhueske.


---

[GitHub] flink pull request #6012: [FLINK-9361] [sql-client] Fix refresh interval in ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6012


---

[GitHub] flink issue #6012: [FLINK-9361] [sql-client] Fix refresh interval in changel...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/6012
  
    Fix looks good.
    +1


---