You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/03/16 15:10:00 UTC
[jira] [Work logged] (AMQNET-831) Allow extra AckTypes when using IndividualAcknowledge
[ https://issues.apache.org/jira/browse/AMQNET-831?focusedWorklogId=851379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-851379 ]
ASF GitHub Bot logged work on AMQNET-831:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Mar/23 15:09
Start Date: 16/Mar/23 15:09
Worklog Time Spent: 10m
Work Description: Jefwillems commented on PR #86:
URL: https://github.com/apache/activemq-nms-amqp/pull/86#issuecomment-1472165175
> @Jefwillems thanks, just need to squash the commits and adjust the commit message to be correctly formed and include the JIRA id.
>
> @Havret any objections here? it looks good to me. On review i noted that we're also missing REJECTED ack type, see here in java variant: https://github.com/apache/qpid-jms/blob/main/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java#L317 Any reason it was left out?
@Havret i tried squashing but something went wrong, i had to reimplement the tests and the reject outcome. The new commits have the Jira issue in them, but i'm afraid if i try squashing again i'll mess things up. In theory, you should be able to squash commits when merging, if you're merging this.
Issue Time Tracking
-------------------
Worklog Id: (was: 851379)
Remaining Estimate: 23h 50m (was: 24h)
Time Spent: 10m
> Allow extra AckTypes when using IndividualAcknowledge
> -----------------------------------------------------
>
> Key: AMQNET-831
> URL: https://issues.apache.org/jira/browse/AMQNET-831
> Project: ActiveMQ .Net
> Issue Type: New Feature
> Components: ActiveMQ, AMQP, NMS
> Affects Versions: AMQP-2.0.0
> Environment: Tested with apache artemis (from the latest image on quay.io/artemiscloud/activemq-artemis-broker)
> Reporter: Jef Willems
> Priority: Major
> Labels: features, pull-request-available
> Original Estimate: 24h
> Time Spent: 10m
> Remaining Estimate: 23h 50m
>
> I wrote a pull request to allow acknowledging messages with different AckType's
> When using individual acknowledgement, the current setup only accepts MODIFIED_FAILED_UNDELIVERABLE as a negative ack, the pull request allows to use MODIFIED_FAILED, REJECTED as ack types. This way the client can automatically use broker redelivery configurations.
> The client library also is more in line with the qpid-jms counterpart when implementing this change: [https://github.com/apache/qpid-jms/blob/main/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java#L323]
>
> The pull request can be found here: https://github.com/apache/activemq-nms-amqp/pull/86
--
This message was sent by Atlassian Jira
(v8.20.10#820010)