You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/17 04:13:06 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4100:
Refactor HelixBrokerStarter to separate constructor and start()
codecov-io edited a comment on issue #4100: Refactor HelixBrokerStarter to separate constructor and start()
URL: https://github.com/apache/incubator-pinot/pull/4100#issuecomment-481500729
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=h1) Report
> Merging [#4100](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/79b33687a7849e01800d5acdd6f2eefecee82998?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `75.92%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4100 +/- ##
============================================
- Coverage 66.82% 66.77% -0.06%
Complexity 20 20
============================================
Files 1036 1036
Lines 51417 51435 +18
Branches 7190 7195 +5
============================================
- Hits 34358 34344 -14
- Misses 14699 14727 +28
- Partials 2360 2364 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...broker/broker/helix/LiveInstanceChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0xpdmVJbnN0YW5jZUNoYW5nZUhhbmRsZXIuamF2YQ==) | `15.21% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/pinot/broker/broker/BrokerServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jyb2tlclNlcnZlckJ1aWxkZXIuamF2YQ==) | `84.21% <100%> (-1.51%)` | `0 <0> (ø)` | |
| [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `74.81% <72.41%> (-1.86%)` | `0 <0> (ø)` | |
| [...inot/broker/queryquota/TableQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9UYWJsZVF1ZXJ5UXVvdGFNYW5hZ2VyLmphdmE=) | `69.48% <83.33%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../broker/routing/HelixExternalViewBasedRouting.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUm91dGluZy5qYXZh) | `88.99% <90%> (+0.06%)` | `0 <0> (ø)` | :arrow_down: |
| [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `55% <0%> (-25%)` | `0% <0%> (ø)` | |
| [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `20.28% <0%> (-23.19%)` | `0% <0%> (ø)` | |
| [...lix/EmptyBrokerOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9FbXB0eUJyb2tlck9ubGluZU9mZmxpbmVTdGF0ZU1vZGVsRmFjdG9yeS5qYXZh) | `86.66% <0%> (-13.34%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `68.88% <0%> (-13.34%)` | `0% <0%> (ø)` | |
| [...pache/pinot/core/util/SortedRangeIntersection.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL1NvcnRlZFJhbmdlSW50ZXJzZWN0aW9uLmphdmE=) | `83.82% <0%> (-7.36%)` | `0% <0%> (ø)` | |
| ... and [26 more](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=footer). Last update [79b3368...fff9cf9](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org