You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2026/09/28 20:13:53 UTC
[PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
slawekjaranowski opened a new pull request, #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325
Only minimal information, as more and more contributors don't use a PR templates at all ...
next steps:
- add bot to check license declaration
- copy body to rest project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325#discussion_r4130104663
##########
.github/pull_request_template.md:
##########
@@ -0,0 +1,11 @@
+
+<!-- Add your description here... what, why and how you resolve the issue -->
+
+---
+
+To make clear that you license your contribution under
+the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
+you have to acknowledge this by using the following check-boxes:
+
+- [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
+- [ ] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Review Comment:
in ASF policy:
> Note that a Corporate CLA does not remove the need for every developer to sign their own ICLA as an individual, which covers both contributions the corporation signing the CCLA owns, and those it does not own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325#issuecomment-5953113987
> question: the new simplified template is a new file how will it replace the old template in projects using the old template?
I will find old tepmpate in each project, check content, group by the same content, verify if not contains something something special
next if ok - update - if will be clear for me I will direct push changes to minimize noifications ...
for not clear I will prepare PR
If you wish I can do a PR for each
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325#issuecomment-5952951884
question: the new simplified template is a new file
how will it replace the old template in projects using the old template?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325#discussion_r4133565765
##########
.github/pull_request_template.md:
##########
@@ -0,0 +1,11 @@
+
+<!-- Add your description here... what, why and how you resolve the issue -->
+
+---
+
+To make clear that you license your contribution under
+the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
+you have to acknowledge this by using the following check-boxes:
Review Comment:
done in 851eb747ce00dc516cb5f12d01da4440b286ee89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325#issuecomment-5877675783
ref:
- #165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325#issuecomment-5878389554
and bot for check
- #326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325#issuecomment-5957373490
rollout documented in #328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on code in PR #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325#discussion_r4127915076
##########
.github/pull_request_template.md:
##########
@@ -0,0 +1,11 @@
+
+<!-- Add your description here... what, why and how you resolve the issue -->
+
+---
+
+To make clear that you license your contribution under
+the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
+you have to acknowledge this by using the following check-boxes:
+
+- [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
+- [ ] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Review Comment:
⚠️ **Incorrect guidance for most contributors** — Not every Apache contributor needs to file an ICLA. Contributors whose employer has signed a Corporate CLA (CCLA) with the ASF are already covered and must NOT file an individual ICLA on top of it. Presenting this as a required checkbox for all contributors is misleading and could cause confusion.
The standard Apache policy is: file an ICLA only if you are contributing as an individual (not on behalf of your employer), or if your company does not have a CCLA. Suggest removing this checkbox from the template, or replacing it with a conditional note pointing to the [ASF CLA policy](https://www.apache.org/licenses/contributor-agreements.html#clas) so contributors can determine which agreement applies to them.
```suggestion
- [ ] I hereby declare that my contribution is covered by the [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) or my employer's [Corporate CLA](https://www.apache.org/licenses/cla-corporate.txt)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325#discussion_r4132430231
##########
.github/pull_request_template.md:
##########
@@ -0,0 +1,11 @@
+
+<!-- Add your description here... what, why and how you resolve the issue -->
+
+---
+
+To make clear that you license your contribution under
+the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
+you have to acknowledge this by using the following check-boxes:
Review Comment:
"you have to acknowledge this by using" is awkward, replace with "check one of"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify GH PR template boilerplate [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #325:
URL: https://github.com/apache/maven-gh-actions-shared/pull/325#issuecomment-5953158592
I will use commits with `ci skip` in massage to not kill CI 😸
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org