You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/12 23:03:44 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #7423: ARROW-8942: [R] Detect compression in reading CSV/JSON
nealrichardson opened a new pull request #7423:
URL: https://github.com/apache/arrow/pull/7423
This extends `make_readable_file` to sniff compression based on the file extension. The switch statement in `detect_compression` is a translation of the `pyarrow` `_detect_compression` function that does the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #7423: ARROW-8942: [R] Detect compression in reading CSV/JSON
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #7423:
URL: https://github.com/apache/arrow/pull/7423#discussion_r440263928
##########
File path: r/tests/testthat/test-csv.R
##########
@@ -168,3 +168,15 @@ test_that("read_csv_arrow() respects col_select", {
tib <- read_csv_arrow(tf, col_select = starts_with("Sepal"), as_data_frame = TRUE)
expect_equal(tib, tibble::tibble(Sepal.Length = iris$Sepal.Length, Sepal.Width = iris$Sepal.Width))
})
+
+test_that("read_csv_arrow() respects col_select", {
Review comment:
Thanks 🤦
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #7423: ARROW-8942: [R] Detect compression in reading CSV/JSON
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #7423:
URL: https://github.com/apache/arrow/pull/7423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7423: ARROW-8942: [R] Detect compression in reading CSV/JSON
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7423:
URL: https://github.com/apache/arrow/pull/7423#issuecomment-643518256
https://issues.apache.org/jira/browse/ARROW-8942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7423: ARROW-8942: [R] Detect compression in reading CSV/JSON
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7423:
URL: https://github.com/apache/arrow/pull/7423#discussion_r439977192
##########
File path: r/tests/testthat/test-csv.R
##########
@@ -168,3 +168,15 @@ test_that("read_csv_arrow() respects col_select", {
tib <- read_csv_arrow(tf, col_select = starts_with("Sepal"), as_data_frame = TRUE)
expect_equal(tib, tibble::tibble(Sepal.Length = iris$Sepal.Length, Sepal.Width = iris$Sepal.Width))
})
+
+test_that("read_csv_arrow() respects col_select", {
Review comment:
Update test description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org