You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/27 09:09:38 UTC

[GitHub] [shardingsphere] jingshanglu opened a new pull request #9189: add check for drop table

jingshanglu opened a new pull request #9189:
URL: https://github.com/apache/shardingsphere/pull/9189


   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero merged pull request #9189: add check for drop table

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #9189:
URL: https://github.com/apache/shardingsphere/pull/9189


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9189: add check for drop table

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9189:
URL: https://github.com/apache/shardingsphere/pull/9189#discussion_r565801070



##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/it/ddl/BaseDDLIT.java
##########
@@ -93,6 +94,7 @@ private void dropInitializedTable(final Connection connection) {
         try (PreparedStatement preparedStatement = connection.prepareStatement(String.format("DROP TABLE %s", getAssertion().getInitialSQL().getAffectedTable()))) {
             preparedStatement.executeUpdate();
         } catch (final SQLException ignored) {
+        } catch (NoSuchTableException ignored) {

Review comment:
       final ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org