You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/04 14:06:30 UTC
Review Request 38120: Add Java Support for QuiesceOffers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
Add Java Support for QuiesceOffers
Diffs
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a89ebed00f93801fc5bfb18e947f7120ef77d095
src/java/src/org/apache/mesos/MesosSchedulerDriver.java b9b2ea8734bb910c543708dd8adcdac45e03c34b
src/java/src/org/apache/mesos/SchedulerDriver.java 183eec898553ed25149c58d2c1f85cf6579d5660
Diff: https://reviews.apache.org/r/38120/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 38120: Add Java Support for QuiesceOffers
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/
-----------------------------------------------------------
(Updated 九月 18, 2015, 3:55 a.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
Add Java Support for QuiesceOffers
Diffs (updated)
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a89ebed00f93801fc5bfb18e947f7120ef77d095
src/java/src/org/apache/mesos/MesosSchedulerDriver.java b9b2ea8734bb910c543708dd8adcdac45e03c34b
src/java/src/org/apache/mesos/SchedulerDriver.java 183eec898553ed25149c58d2c1f85cf6579d5660
Diff: https://reviews.apache.org/r/38120/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 38120: Add Java Support for QuiesceOffers
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/
-----------------------------------------------------------
(Updated 九月 16, 2015, 5:50 a.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
Add Java Support for QuiesceOffers
Diffs (updated)
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a89ebed00f93801fc5bfb18e947f7120ef77d095
src/java/src/org/apache/mesos/MesosSchedulerDriver.java b9b2ea8734bb910c543708dd8adcdac45e03c34b
src/java/src/org/apache/mesos/SchedulerDriver.java 183eec898553ed25149c58d2c1f85cf6579d5660
Diff: https://reviews.apache.org/r/38120/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 38120: Add Java Support for QuiesceOffers
Posted by Vinod Kone <vi...@gmail.com>.
> On Sept. 15, 2015, 7:12 p.m., Vinod Kone wrote:
> >
>
> Vinod Kone wrote:
> can you also update the java test framework to test this call?
>
> Guangya Liu wrote:
> I see that the reviveOffers also do not have a example, I want to handle those two APIs together in another patch, make sense? Thanks.
sg, please create a ticket if you haven't already.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/#review99071
-----------------------------------------------------------
On Sept. 16, 2015, 5:50 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38120/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 5:50 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add Java Support for QuiesceOffers
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a89ebed00f93801fc5bfb18e947f7120ef77d095
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java b9b2ea8734bb910c543708dd8adcdac45e03c34b
> src/java/src/org/apache/mesos/SchedulerDriver.java 183eec898553ed25149c58d2c1f85cf6579d5660
>
> Diff: https://reviews.apache.org/r/38120/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 38120: Add Java Support for QuiesceOffers
Posted by Guangya Liu <gy...@gmail.com>.
> On 九月 15, 2015, 7:12 p.m., Vinod Kone wrote:
> >
>
> Vinod Kone wrote:
> can you also update the java test framework to test this call?
>
> Guangya Liu wrote:
> I see that the reviveOffers also do not have a example, I want to handle those two APIs together in another patch, make sense? Thanks.
>
> Vinod Kone wrote:
> sg, please create a ticket if you haven't already.
Filed a bug https://issues.apache.org/jira/browse/MESOS-3460 here, Thanks!
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/#review99071
-----------------------------------------------------------
On 九月 18, 2015, 3:55 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38120/
> -----------------------------------------------------------
>
> (Updated 九月 18, 2015, 3:55 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add Java Support for QuiesceOffers
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a89ebed00f93801fc5bfb18e947f7120ef77d095
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java b9b2ea8734bb910c543708dd8adcdac45e03c34b
> src/java/src/org/apache/mesos/SchedulerDriver.java 183eec898553ed25149c58d2c1f85cf6579d5660
>
> Diff: https://reviews.apache.org/r/38120/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 38120: Add Java Support for QuiesceOffers
Posted by Guangya Liu <gy...@gmail.com>.
> On 九月 15, 2015, 7:12 p.m., Vinod Kone wrote:
> >
>
> Vinod Kone wrote:
> can you also update the java test framework to test this call?
I see that the reviveOffers also do not have a example, I want to handle those two APIs together in another patch, make sense? Thanks.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/#review99071
-----------------------------------------------------------
On 九月 4, 2015, 12:06 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38120/
> -----------------------------------------------------------
>
> (Updated 九月 4, 2015, 12:06 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add Java Support for QuiesceOffers
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a89ebed00f93801fc5bfb18e947f7120ef77d095
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java b9b2ea8734bb910c543708dd8adcdac45e03c34b
> src/java/src/org/apache/mesos/SchedulerDriver.java 183eec898553ed25149c58d2c1f85cf6579d5660
>
> Diff: https://reviews.apache.org/r/38120/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 38120: Add Java Support for QuiesceOffers
Posted by Vinod Kone <vi...@gmail.com>.
> On Sept. 15, 2015, 7:12 p.m., Vinod Kone wrote:
> >
can you also update the java test framework to test this call?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/#review99071
-----------------------------------------------------------
On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38120/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 12:06 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add Java Support for QuiesceOffers
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a89ebed00f93801fc5bfb18e947f7120ef77d095
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java b9b2ea8734bb910c543708dd8adcdac45e03c34b
> src/java/src/org/apache/mesos/SchedulerDriver.java 183eec898553ed25149c58d2c1f85cf6579d5660
>
> Diff: https://reviews.apache.org/r/38120/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 38120: Add Java Support for QuiesceOffers
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/#review99071
-----------------------------------------------------------
Ship it!
src/java/src/org/apache/mesos/SchedulerDriver.java (lines 254 - 255)
<https://reviews.apache.org/r/38120/#comment155903>
Just have the same comment that you had on scheduler.hpp in the first review of this chain.
- Vinod Kone
On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38120/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 12:06 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add Java Support for QuiesceOffers
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a89ebed00f93801fc5bfb18e947f7120ef77d095
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java b9b2ea8734bb910c543708dd8adcdac45e03c34b
> src/java/src/org/apache/mesos/SchedulerDriver.java 183eec898553ed25149c58d2c1f85cf6579d5660
>
> Diff: https://reviews.apache.org/r/38120/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>