You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Christian Schaffner <sc...@eeh.ee.ethz.ch> on 2002/04/15 14:34:52 UTC

rMacOS X: Test failure with r1682+

Hi

I did a subversion package for fink (http://fink.sourceforge.net) on 
MacOS X. Tarball r1587 worked fine. Today I upgraded the package to 
r1682+ and got the following test failure:

---------------------------
  make check
Running all tests in path-test...success
Running all tests in random-test...success
Running all tests in hashdump-test...success
Running all tests in stringtest...success
Running all tests in translate-test...success
Running all tests in svn-test.sh...success
Running all tests in svn-test2.sh...success
Running all tests in target-test.sh...success
Running all tests in run-fs-tests.sh...success
Running all tests in run-repos-tests.sh...success
Running all tests in getopt_tests.py...FAILURE
Running all tests in basic_tests.py...success
Running all tests in commit_tests.py...success
Running all tests in update_tests.py...success
Running all tests in prop_tests.py...success
Running all tests in schedule_tests.py...success
Running all tests in log_tests.py...success
Running all tests in copy_tests.py...success
Running all tests in diff_tests.py...success
Running all tests in stat_tests.py...success
Running all tests in trans_tests.py...success
Running all tests in svnadmin_tests.py...success
At least one test FAILED, checking 
/sw/src/subversion-r1682+-1/subversion-r1682+/tests.log
FAIL: getopt_tests.py 2: run svn --version
---------------------------

The relevant output from the tests.log file looks like this:
---------------------------
START: getopt_tests.py
PASS: getopt_tests.py 1: run svn with no arguments
Standard output does not match.
Expected standard output:
['Subversion Client, version X.Y.Z (dev build)\n', '\n', 'Copyright 
(C) 2000-2002 CollabNet.\n', 'Subversion is open source software, see 
http://subversion.tigris.org/\n', '\n', 'The following repository 
access (RA) modules are available:\n', '\n', '* ra_dav : Module for 
accessing a repository via WebDAV (DeltaV) protocol.\n', "  - handles 
'http' schema\n", '* ra_local : Module for accessing a repository on 
local disk.\n', '\n']

Actual standard output:
['Subversion Client, version X.Y.Z (r1692)\n', '\n', 'Copyright (C) 
2000-2002 CollabNet.\n', 'Subversion is open source software, see 
http://subversion.tigris.org/\n', '\n', 'The following repository 
access (RA) modules are available:\n', '\n', '* ra_dav : Module for 
accessing a repository via WebDAV (DeltaV) protocol.\n', "  - handles 
'http' schema\n", '* ra_local : Module for accessing a repository on 
local disk.\n', '\n']

FAIL: getopt_tests.py 2: run svn --version
PASS: getopt_tests.py 3: run svn --help
PASS: getopt_tests.py 4: run svn help
PASS: getopt_tests.py 5: run svn help --version
PASS: getopt_tests.py 6: run svn help bogus-cmd
PASS: getopt_tests.py 7: run svn help log switch
END: getopt_tests.py
---------------------------

Has anybody got any ideas why this could have happened? The package 
still works fine and I was able to check out a working copy of the 
subversion source tree without any problems.

Thanks,
Chris.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: rMacOS X: Test failure with r1682+

Posted by Blair Zajac <bl...@orcaware.com>.
Karl Fogel wrote:
> 
> Ben Collins-Sussman <su...@collab.net> writes:
> > Actually, this is a 'feature' that was added to our tarball-generating
> > script (dist.sh).  It patches svn_version.h to include the exact
> > revision number of the tarball, whereas normally the value is just the
> > string "dev build".  IIRC, this was added as a way of knowing whether
> > somebody was using a client built from tarball, or if they're using
> > HEAD.  Just run 'svn --version' and see.
> >
> > Of course, I guess this means that 'make check' won't work for a
> > tarball build.  Unless, of course, we patch getopt_tests.py in the
> > tarball as well.   :-)
> 
> Whoa.  That's ridiculous -- the tarballs need to pass 'make check'. :-)
> 
> Blair, can you review my fix in revision 1717?  Thanks.
> 
> -K

The fix looks fine.

Best,
Blair

-- 
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: rMacOS X: Test failure with r1682+

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Ben Collins-Sussman <su...@collab.net> writes:
> Actually, this is a 'feature' that was added to our tarball-generating
> script (dist.sh).  It patches svn_version.h to include the exact
> revision number of the tarball, whereas normally the value is just the
> string "dev build".  IIRC, this was added as a way of knowing whether
> somebody was using a client built from tarball, or if they're using
> HEAD.  Just run 'svn --version' and see.
> 
> Of course, I guess this means that 'make check' won't work for a
> tarball build.  Unless, of course, we patch getopt_tests.py in the
> tarball as well.   :-)

Whoa.  That's ridiculous -- the tarballs need to pass 'make check'. :-)

Blair, can you review my fix in revision 1717?  Thanks.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: rMacOS X: Test failure with r1682+

Posted by Max Horn <ma...@quendi.de>.
At 10:20 Uhr -0500 15.04.2002, Ben Collins-Sussman wrote:
>Max Horn <ma...@quendi.de> writes:
>
>>  Looks to me like a bug in the test - the lines are identical execpt
>>  for the text "r1692" vs. "dev build". I'd not worry much about it,
>>  though I wonder why this happens... a bug in the tarball?
>
>Actually, this is a 'feature' that was added to our tarball-generating
>script (dist.sh).  It patches svn_version.h to include the exact
>revision number of the tarball, whereas normally the value is just the
>string "dev build".  IIRC, this was added as a way of knowing whether
>somebody was using a client built from tarball, or if they're using
>HEAD.  Just run 'svn --version' and see.
>
>Of course, I guess this means that 'make check' won't work for a
>tarball build.  Unless, of course, we patch getopt_tests.py in the
>tarball as well.   :-)

I think you should do that.


Max
-- 
-----------------------------------------------
Max Horn
Software Developer

email: <ma...@quendi.de>
phone: (+49) 6151-494890

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: rMacOS X: Test failure with r1682+

Posted by Ben Collins-Sussman <su...@collab.net>.
Max Horn <ma...@quendi.de> writes:

> Looks to me like a bug in the test - the lines are identical execpt
> for the text "r1692" vs. "dev build". I'd not worry much about it,
> though I wonder why this happens... a bug in the tarball?

Actually, this is a 'feature' that was added to our tarball-generating
script (dist.sh).  It patches svn_version.h to include the exact
revision number of the tarball, whereas normally the value is just the
string "dev build".  IIRC, this was added as a way of knowing whether
somebody was using a client built from tarball, or if they're using
HEAD.  Just run 'svn --version' and see.

Of course, I guess this means that 'make check' won't work for a
tarball build.  Unless, of course, we patch getopt_tests.py in the
tarball as well.   :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: rMacOS X: Test failure with r1682+

Posted by Max Horn <ma...@quendi.de>.
At 16:34 Uhr +0200 15.04.2002, Christian Schaffner wrote:
>Hi
>
>I did a subversion package for fink (http://fink.sourceforge.net) on 
>MacOS X. Tarball r1587 worked fine. Today I upgraded the package to 
>r1682+ and got the following test failure:

[...]

>The relevant output from the tests.log file looks like this:
>---------------------------
>START: getopt_tests.py
>PASS: getopt_tests.py 1: run svn with no arguments
>Standard output does not match.
>Expected standard output:
>['Subversion Client, version X.Y.Z (dev build)\n', '\n', 'Copyright 
>(C) 2000-2002 CollabNet.\n', 'Subversion is open source software, 
>see http://subversion.tigris.org/\n', '\n', 'The following 
>repository access (RA) modules are available:\n', '\n', '* ra_dav : 
>Module for accessing a repository via WebDAV (DeltaV) protocol.\n', 
>"  - handles 'http' schema\n", '* ra_local : Module for accessing a 
>repository on local disk.\n', '\n']
>
>Actual standard output:
>['Subversion Client, version X.Y.Z (r1692)\n', '\n', 'Copyright (C) 
>2000-2002 CollabNet.\n', 'Subversion is open source software, see 
>http://subversion.tigris.org/\n', '\n', 'The following repository 
>access (RA) modules are available:\n', '\n', '* ra_dav : Module for 
>accessing a repository via WebDAV (DeltaV) protocol.\n', "  - 
>handles 'http' schema\n", '* ra_local : Module for accessing a 
>repository on local disk.\n', '\n']

[...]

>Has anybody got any ideas why this could have happened? The package 
>still works fine and I was able to check out a working copy of the 
>subversion source tree without any problems.

Looks to me like a bug in the test - the lines are identical execpt 
for the text "r1692" vs. "dev build". I'd not worry much about it, 
though I wonder why this happens... a bug in the tarball?


Max
-- 
-----------------------------------------------
Max Horn
Software Developer

email: <ma...@quendi.de>
phone: (+49) 6151-494890

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org