You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2014/04/07 16:50:27 UTC
svn commit: r1585496 -
/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
Author: ggregory
Date: Mon Apr 7 14:50:26 2014
New Revision: 1585496
URL: http://svn.apache.org/r1585496
Log:
[CSV-110] Add ability to parse single lines.
Modified:
commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
Modified: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java?rev=1585496&r1=1585495&r2=1585496&view=diff
==============================================================================
--- commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java (original)
+++ commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java Mon Apr 7 14:50:26 2014
@@ -435,7 +435,7 @@ public final class CSVParser implements
* @throws IOException
* on parse error or input read-failure
*/
- CSVRecord nextRecord() throws IOException {
+ public CSVRecord nextRecord() throws IOException {
CSVRecord result = null;
this.record.clear();
StringBuilder sb = null;
Re: svn commit: r1585496 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
Posted by Gary Gregory <ga...@gmail.com>.
Well, let's discuss, I've started another thread on the ML at the time of
the commit. :)
The reason I committed the visibility change is that I wanted the user to
be able to download and play with an alternate implementation than what I
feel is a weird bolt-on.
Gary
On Mon, Apr 7, 2014 at 2:55 PM, Benedikt Ritter <br...@apache.org> wrote:
> Well you're mail indicated you wanted to discuss this first. I'd like to
> leave this out of 1.0 and really think this through.
>
>
> 2014-04-07 16:50 GMT+02:00 <gg...@apache.org>:
>
> > Author: ggregory
> > Date: Mon Apr 7 14:50:26 2014
> > New Revision: 1585496
> >
> > URL: http://svn.apache.org/r1585496
> > Log:
> > [CSV-110] Add ability to parse single lines.
> >
> > Modified:
> >
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> >
> > Modified:
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> > URL:
> >
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java?rev=1585496&r1=1585495&r2=1585496&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> > (original)
> > +++
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> > Mon Apr 7 14:50:26 2014
> > @@ -435,7 +435,7 @@ public final class CSVParser implements
> > * @throws IOException
> > * on parse error or input read-failure
> > */
> > - CSVRecord nextRecord() throws IOException {
> > + public CSVRecord nextRecord() throws IOException {
> > CSVRecord result = null;
> > this.record.clear();
> > StringBuilder sb = null;
> >
> >
> >
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1585496 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
Posted by Benedikt Ritter <br...@apache.org>.
Well you're mail indicated you wanted to discuss this first. I'd like to
leave this out of 1.0 and really think this through.
2014-04-07 16:50 GMT+02:00 <gg...@apache.org>:
> Author: ggregory
> Date: Mon Apr 7 14:50:26 2014
> New Revision: 1585496
>
> URL: http://svn.apache.org/r1585496
> Log:
> [CSV-110] Add ability to parse single lines.
>
> Modified:
>
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
>
> Modified:
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java?rev=1585496&r1=1585495&r2=1585496&view=diff
>
> ==============================================================================
> ---
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> (original)
> +++
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> Mon Apr 7 14:50:26 2014
> @@ -435,7 +435,7 @@ public final class CSVParser implements
> * @throws IOException
> * on parse error or input read-failure
> */
> - CSVRecord nextRecord() throws IOException {
> + public CSVRecord nextRecord() throws IOException {
> CSVRecord result = null;
> this.record.clear();
> StringBuilder sb = null;
>
>
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter