You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/10/23 10:48:39 UTC

[GitHub] [rocketmq] chenliuyang1989 opened a new issue #2375: remove unnecessary parameter dataTopic for method AsyncTraceDispatcher.sendTraceDataByMQ

chenliuyang1989 opened a new issue #2375:
URL: https://github.com/apache/rocketmq/issues/2375


   1. we have defined the traceTopicName In the construction method
      
   ![image](https://user-images.githubusercontent.com/4150132/96994956-0895a280-1560-11eb-86cf-99fd3be8c19b.png)
   
   2. no need to pass unused param dataTopic again at AsyncTraceDispatcher.sendTraceDataByMQ 
    
   ![image](https://user-images.githubusercontent.com/4150132/96995104-409ce580-1560-11eb-9460-1b8f53aa86f7.png)
   
   can i remove this unused param？
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] chenliuyang1989 closed issue #2375: remove unnecessary parameter dataTopic for method AsyncTraceDispatcher.sendTraceDataByMQ

Posted by GitBox <gi...@apache.org>.

chenliuyang1989 closed issue #2375:
URL: https://github.com/apache/rocketmq/issues/2375


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] chenliuyang1989 commented on issue #2375: remove unnecessary parameter dataTopic for method AsyncTraceDispatcher.sendTraceDataByMQ

Posted by GitBox <gi...@apache.org>.

chenliuyang1989 commented on issue #2375:
URL: https://github.com/apache/rocketmq/issues/2375#issuecomment-757121048


   no response


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on issue #2375: remove unnecessary parameter dataTopic for method AsyncTraceDispatcher.sendTraceDataByMQ

Posted by GitBox <gi...@apache.org>.

duhenglucky commented on issue #2375:
URL: https://github.com/apache/rocketmq/issues/2375#issuecomment-721615676


   @chenliuyang1989 thanks for your advice, but actually maybe this function and this parameter has been used by other users.
   but a discussion is welcome.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] chenliuyang1989 commented on issue #2375: remove unnecessary parameter dataTopic for method AsyncTraceDispatcher.sendTraceDataByMQ

Posted by GitBox <gi...@apache.org>.

chenliuyang1989 commented on issue #2375:
URL: https://github.com/apache/rocketmq/issues/2375#issuecomment-757121048


   no response


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] chenliuyang1989 closed issue #2375: remove unnecessary parameter dataTopic for method AsyncTraceDispatcher.sendTraceDataByMQ

Posted by GitBox <gi...@apache.org>.

chenliuyang1989 closed issue #2375:
URL: https://github.com/apache/rocketmq/issues/2375


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] chenliuyang1989 commented on issue #2375: remove unnecessary parameter dataTopic for method AsyncTraceDispatcher.sendTraceDataByMQ

Posted by GitBox <gi...@apache.org>.

chenliuyang1989 commented on issue #2375:
URL: https://github.com/apache/rocketmq/issues/2375#issuecomment-722955067


   ![image](https://user-images.githubusercontent.com/4150132/98344959-f41cd400-204e-11eb-8bc7-ed0684d6f502.png)
   
   Please find my screenshot，the traceTopic is not defined by dataTopic，so dataTopic is not used anymore in method sendTraceDataByMQ，i think we can remove this param


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org