[GitHub] [skywalking] wankai123 commented on a change in pull request #8367: Support OAP server v9 Core concept: Layer, backend side

[GitBox <gi...@apache.org>]

wankai123 commented on a change in pull request #8367:
URL: https://github.com/apache/skywalking/pull/8367#discussion_r777111845



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/query/IMetadataQueryDAO.java
##########
@@ -20,58 +20,37 @@
 
 import java.io.IOException;
 import java.util.List;
-import org.apache.skywalking.oap.server.core.analysis.NodeType;
-import org.apache.skywalking.oap.server.core.query.type.Database;
 import org.apache.skywalking.oap.server.core.query.type.Endpoint;
 import org.apache.skywalking.oap.server.core.query.type.Service;
 import org.apache.skywalking.oap.server.core.query.type.ServiceInstance;
 import org.apache.skywalking.oap.server.core.storage.DAO;
 
 public interface IMetadataQueryDAO extends DAO {
     /**
-     * @param group group name for filtering.
-     * @return list of the all available normal services
+     * @param layer layer name for filtering
+     * @param group group name for filtering
+     * @return list of the all available services
      */
-    List<Service> getAllServices(final String group) throws IOException;
+    List<Service> listServices(final String layer, final String group) throws IOException;
 
-    /**
-     * @return list of the all available browser services
-     */
-    List<Service> getAllBrowserServices() throws IOException;
-
-    /**
-     * @return list of all conjecture database services.
-     */
-    List<Database> getAllDatabases() throws IOException;
+    Service findService(final String serviceId) throws IOException;
 
     /**
-     * @param nodeType describe which kind of node of Service
-     * @param keyword  to filter the normal service
-     * @return the list of normal services matching the given keyword
+     * @param startTimestamp The instance is required to be live after this timestamp
+     * @param endTimestamp   The instance is required to be live before this timestamp.
+     * @param serviceId      the owner of the instances.
+     * @return list of instances matching the given conditions.
      */
-    List<Service> searchServices(final NodeType nodeType, final String keyword) throws IOException;
+    List<ServiceInstance> listInstances(final long startTimestamp, final long endTimestamp,
+                                        final String serviceId) throws IOException;
 
-    /**
-     * @param nodeType    describe which kind of node of Service
-     * @param serviceCode to literal match
-     * @return the service matching the given full name.
-     */
-    Service searchService(final NodeType nodeType, final String serviceCode) throws IOException;
+    ServiceInstance getInstance(final String instanceId) throws IOException;

Review comment:
       Manual tested, it works fine. Once CLI supported the new query, I'll add the new verify.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org