You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/07/26 08:53:37 UTC

[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #864: Block cleaner should catch NonFatal exception

ulysses-you commented on a change in pull request #864:
URL: https://github.com/apache/incubator-kyuubi/pull/864#discussion_r676415418



##########
File path: tools/spark-block-cleaner/src/main/scala/org/apache/kyuubi/tools/KubernetesSparkBlockCleaner.scala
##########
@@ -185,8 +187,14 @@ object KubernetesSparkBlockCleaner extends Logging {
       val hasFinished = new CountDownLatch(cacheDirs.length)
       cacheDirs.foreach { dir =>
         threadPool.execute(() => {
-          doCleanJob(dir)
-          hasFinished.countDown()
+          try {
+            doCleanJob(dir)
+          } catch {
+            case NonFatal(e) =>
+              error("failed to clean", e)

Review comment:
       added




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org