You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "RongtongJin (via GitHub)" <gi...@apache.org> on 2023/05/11 06:38:33 UTC
[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #6733: Make configPath unable to update at runtime
RongtongJin commented on code in PR #6733:
URL: https://github.com/apache/rocketmq/pull/6733#discussion_r1190699472
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -775,13 +775,21 @@ private synchronized RemotingCommand updateBrokerConfig(ChannelHandlerContext ct
String bodyStr = new String(body, MixAll.DEFAULT_CHARSET);
Properties properties = MixAll.string2Properties(bodyStr);
if (properties != null) {
- LOGGER.info("updateBrokerConfig, new config: [{}] client: {} ", properties, ctx.channel().remoteAddress());
+ LOGGER.info("updateBrokerConfig, new config: [{}] client: {} ", properties, callerAddress);
+
+ if (properties.containsKey("brokerConfigPath")) {
+ response.setCode(ResponseCode.SYSTEM_ERROR);
Review Comment:
done
##########
controller/src/main/java/org/apache/rocketmq/controller/processor/ControllerRequestProcessor.java:
##########
@@ -241,6 +241,12 @@ private RemotingCommand handleUpdateControllerConfig(ChannelHandlerContext ctx,
return response;
}
+ if (properties.containsKey("configStorePath")) {
+ response.setCode(ResponseCode.SYSTEM_ERROR);
Review Comment:
> Same here.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org