You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org> on 2019/01/24 20:50:00 UTC

[jira] [Resolved] (RATIS-412) In RaftLog, change lastCommitted to private

     [ https://issues.apache.org/jira/browse/RATIS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo Nicholas Sze resolved RATIS-412.
---------------------------------------
    Resolution: Not A Problem

[~dineshchitlangia], you are right that the code has been changed.  This is no longer a problem.  Thanks.

> In RaftLog, change lastCommitted to private
> -------------------------------------------
>
>                 Key: RATIS-412
>                 URL: https://issues.apache.org/jira/browse/RATIS-412
>             Project: Ratis
>          Issue Type: Improvement
>          Components: server
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>              Labels: newbie
>
> lastCommitted is only used once outside RaftLog.  The usage is in a SegmentedRaftLog constructor.  We should change lastCommitted to private.
> Then, SegmentedRaftLog could initialize lastCommitted using a RaftLog constructor (needs to add a parameter.)
> BTW, let's also rename lastCommitted to commitIndex so that it is consistent with other code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)