You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/18 12:11:49 UTC
[GitHub] [iotdb] wangchao316 opened a new pull request #2667: [IOTDB-1152] optimize regular data size in traversing
wangchao316 opened a new pull request #2667:
URL: https://github.com/apache/iotdb/pull/2667
data[] storage data in RegularDataEncoder, data[] default-size is 128, if real data < 128, but traversing 128 times in data2Diff method, which can use real data size...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #2667: [IOTDB-1152] optimize regular data size in traversing
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #2667:
URL: https://github.com/apache/iotdb/pull/2667#discussion_r580726201
##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/RegularDataEncoder.java
##########
@@ -220,7 +223,7 @@ private void data2Diff(int[] missingPointData) {
bitmap = new BitSet(newBlockSize);
bitmap.flip(0, newBlockSize);
int offset = 0;
- for (int i = 1; i < missingPointData.length; i++) {
+ for (int i = 1; i < dataTotal; i++) {
Review comment:
Just a small suggestion, would you like adding some the comments here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #2667: [IOTDB-1152] optimize regular data size in traversing
Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #2667:
URL: https://github.com/apache/iotdb/pull/2667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #2667: [IOTDB-1152] optimize regular data size in traversing
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #2667:
URL: https://github.com/apache/iotdb/pull/2667#discussion_r580726201
##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/RegularDataEncoder.java
##########
@@ -220,7 +223,7 @@ private void data2Diff(int[] missingPointData) {
bitmap = new BitSet(newBlockSize);
bitmap.flip(0, newBlockSize);
int offset = 0;
- for (int i = 1; i < missingPointData.length; i++) {
+ for (int i = 1; i < dataTotal; i++) {
Review comment:
Just a small suggestion, would you like adding some the comments here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on pull request #2667: [IOTDB-1152] optimize regular data size in traversing
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on pull request #2667:
URL: https://github.com/apache/iotdb/pull/2667#issuecomment-781785154
@qiaojialin @jixuan1989 , hi , could you please review this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 closed pull request #2667: [IOTDB-1152] optimize regular data size in traversing
Posted by GitBox <gi...@apache.org>.
wangchao316 closed pull request #2667:
URL: https://github.com/apache/iotdb/pull/2667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org