You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/16 05:11:00 UTC
[GitHub] [cordova-android] erisu opened a new pull request #896:
dFeat/kotlin support
erisu opened a new pull request #896: dFeat/kotlin support
URL: https://github.com/apache/cordova-android/pull/896
### Motivation and Context
To finish off the change requests and close out PR #441
closes: #441
### Description
What this PR does:
* Cherry-picks commit changes from #441
* Rename preference option `EnableKotlin` to `KotlinEnabled` (Default: `false`)
* Since the preference has not been released or used in any other repos, the name change is safe. This change is only an update from the original PR's proposal.
* Added preference options `KotlinCodeStyle` (Default: `official`)
* Added preference option `KotlinVersion` (Default: `1.3.41`)
* Apply `kotlin-android-extensions` plugin as well when `EnableKotlin` is `true`
* Changed `compile` to `implementation`
### Testing
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary (*Pending Work for Cordova Docs Repo*)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on issue #896: feat: add
kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/a95179343142318ee64a043f5b5a03063d7b016d?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.17% 66.03% -0.15%
==========================================
Files 19 19
Lines 1839 1843 +4
==========================================
Hits 1217 1217
- Misses 622 626 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [a951793...babf7a5](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on a change in pull request #896:
feat: add kotlin support
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#discussion_r368475218
##########
File path: bin/templates/project/build.gradle
##########
@@ -19,16 +19,16 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
+ ext.kotlin_version = '1.3.50'
Review comment:
Yes, if you create a blank "No Activity" project in Android Studio, it has in the project's `build.gradle`:
```
ext.kotlin_version = '1.3.50'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat:
add kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/8ef742e79d80631206439f516fefede652873331?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.17% 66.03% -0.15%
==========================================
Files 19 19
Lines 1839 1843 +4
==========================================
Hits 1217 1217
- Misses 622 626 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [8ef742e...0f61780](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] dpogue commented on issue #896: feat: add kotlin
support
Posted by GitBox <gi...@apache.org>.
dpogue commented on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574997513
> @timbru31 I just added the Kotlin source set as well, per your change request's overview comment. The only thing I was not sure is if it was necessary to wrap that behind a flag too.
IMO no need for a flag for adding the src/main/kotlin folder. Note that currently all plugin source files will end up in src/main/java because there's no special handling to detect kotlin files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat:
add kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/a95179343142318ee64a043f5b5a03063d7b016d?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.17% 66.03% -0.15%
==========================================
Files 19 19
Lines 1839 1843 +4
==========================================
Hits 1217 1217
- Misses 622 626 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [a951793...742643d](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat:
add kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/09256b766f2d71863693c27996329e59909fec11?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.17% 66.03% -0.15%
==========================================
Files 19 19
Lines 1839 1843 +4
==========================================
Hits 1217 1217
- Misses 622 626 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [09256b7...7e5443d](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat:
add kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/09256b766f2d71863693c27996329e59909fec11?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.17% 66.03% -0.15%
==========================================
Files 19 19
Lines 1839 1843 +4
==========================================
Hits 1217 1217
- Misses 622 626 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [09256b7...7e5443d](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #896: feat: add kotlin
support
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574996574
@timbru31 I just added the Kotlin source set as well, per your change request's overview comment. The only thing I was not sure is if it was necessary to wrap that behind a flag too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat:
add kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/09256b766f2d71863693c27996329e59909fec11?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.17% 66.03% -0.15%
==========================================
Files 19 19
Lines 1839 1843 +4
==========================================
Hits 1217 1217
- Misses 622 626 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [09256b7...c66388c](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat:
add kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/d01ed80a61c765483c60d5bbf737e71d5fb14b43?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.41% 66.27% -0.15%
==========================================
Files 19 19
Lines 1849 1853 +4
==========================================
Hits 1228 1228
- Misses 621 625 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `34.65% <0%> (-0.47%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [d01ed80...99ee5d0](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #896: feat: add kotlin
support
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574994317
@timbru31
I went ahead and created a new Kotlin support PR so we can quickly apply all the changes and improvements to get Kotlin prepared and released hopefully in the next day or 2.
Per your change request in the previous PR, I have:
* Updated Kotlin to the latest version
* Replaced `mavenCentral` with `jcenter` in the `test/app/build.gradle`
**NOTICE**:
This change is not applied to the actual `build.gradle` that is used when building a Cordova project. The actual file, `bin/templates/project/app/build.gradle`, still uses in the following order:
mavenCentral -> google -> jcenter
If these are to be updated, it should be taken care of in a separate PR
* Per your comment about `kotlin:kotlin-stdlib-jdk7` I believe it is best to keep it as `kotlin:kotlin-stdlib-jdk7`. A newly created Android project with the official Android Studio uses `kotlin:kotlin-stdlib-jdk7`. Probably best to not do something different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat:
add kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/a95179343142318ee64a043f5b5a03063d7b016d?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.17% 66.03% -0.15%
==========================================
Files 19 19
Lines 1839 1843 +4
==========================================
Hits 1217 1217
- Misses 622 626 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [a951793...742643d](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat:
add kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/8ef742e79d80631206439f516fefede652873331?src=pr&el=desc) will **increase** coverage by `0.23%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
+ Coverage 66.17% 66.41% +0.23%
==========================================
Files 19 19
Lines 1839 1849 +10
==========================================
+ Hits 1217 1228 +11
+ Misses 622 621 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: |
| [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100% <0%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `53.5% <0%> (+3.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [8ef742e...18f9fe3](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #896: feat: add kotlin
support
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] timbru31 commented on a change in pull request
#896: feat: add kotlin support
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#discussion_r368468517
##########
File path: bin/templates/project/build.gradle
##########
@@ -19,16 +19,16 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
+ ext.kotlin_version = '1.3.50'
Review comment:
is this the Android Studio default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat:
add kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/d01ed80a61c765483c60d5bbf737e71d5fb14b43?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.41% 66.27% -0.15%
==========================================
Files 19 19
Lines 1849 1853 +4
==========================================
Hits 1228 1228
- Misses 621 625 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `34.65% <0%> (-0.47%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [d01ed80...99ee5d0](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat:
add kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/09256b766f2d71863693c27996329e59909fec11?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.17% 66.03% -0.15%
==========================================
Files 19 19
Lines 1839 1843 +4
==========================================
Hits 1217 1217
- Misses 622 626 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [09256b7...7ac1c35](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat:
add kotlin support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/8ef742e79d80631206439f516fefede652873331?src=pr&el=desc) will **increase** coverage by `0.23%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
+ Coverage 66.17% 66.41% +0.23%
==========================================
Files 19 19
Lines 1839 1849 +10
==========================================
+ Hits 1217 1228 +11
+ Misses 622 621 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: |
| [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100% <0%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `53.5% <0%> (+3.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=footer). Last update [8ef742e...18f9fe3](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org