[GitHub] [hive] abstractdog commented on a change in pull request #2278: HIVE-24945: Support vectorization for lead/lag functions

[GitBox <gi...@apache.org>]

abstractdog commented on a change in pull request #2278:
URL: https://github.com/apache/hive/pull/2278#discussion_r657007751



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/VectorPTFDesc.java
##########
@@ -172,8 +179,8 @@ public VectorPTFDesc() {
 
   // We provide this public method to help EXPLAIN VECTORIZATION show the evaluator classes.
   public static VectorPTFEvaluatorBase getEvaluator(SupportedFunctionType functionType,
-      boolean isDistinct, WindowFrameDef windowFrameDef, Type columnVectorType,
-      VectorExpression inputVectorExpression, int outputColumnNum) {
+      List<ExprNodeDesc> evaluatorParameters, boolean isDistinct, WindowFrameDef windowFrameDef,

Review comment:
       right, I'm removing this, we can put back later if needed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org