You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2022/06/10 00:14:46 UTC

[GitHub] [parquet-mr] sunchao opened a new pull request, #973: Upgrade protobuf version to 3.20.1

sunchao opened a new pull request, #973:
URL: https://github.com/apache/parquet-mr/pull/973

   Currently the repo can't be compiled with M1 Mac:
   ```
   com.google.protobuf:protoc:exe:osx-aarch_64:3.16.1 was not found in https://jitpack.io/ during a previous attempt.
   ```
   
   since the artifact for M1 arch was not published: https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.16.1/
   
   This upgrade the protobuf version to 3.20.1 to support compiling on M1 Mac.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-2155
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] sunchao commented on pull request #973: PARQUET-2155: Upgrade protobuf version to 3.20.1

Posted by GitBox <gi...@apache.org>.
sunchao commented on PR #973:
URL: https://github.com/apache/parquet-mr/pull/973#issuecomment-1152586301

   cc @ggershinsky @shangxinli 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] ggershinsky merged pull request #973: PARQUET-2155: Upgrade protobuf version to 3.17.3

Posted by GitBox <gi...@apache.org>.
ggershinsky merged PR #973:
URL: https://github.com/apache/parquet-mr/pull/973


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on pull request #973: PARQUET-2155: Upgrade protobuf version to 3.20.1

Posted by GitBox <gi...@apache.org>.
shangxinli commented on PR #973:
URL: https://github.com/apache/parquet-mr/pull/973#issuecomment-1172920087

   Yeah, we can do 3.20.1 later.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] steveloughran commented on pull request #973: PARQUET-2155: Upgrade protobuf version to 3.20.1

Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #973:
URL: https://github.com/apache/parquet-mr/pull/973#issuecomment-1152148534

   ...but the #970 patch should add a comment saying "not needed once protobuf is incremented to 3.20+"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] sunchao commented on pull request #973: PARQUET-2155: Upgrade protobuf version to 3.17.3

Posted by GitBox <gi...@apache.org>.
sunchao commented on PR #973:
URL: https://github.com/apache/parquet-mr/pull/973#issuecomment-1172949094

   updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] ggershinsky commented on pull request #973: PARQUET-2155: Upgrade protobuf version to 3.17.3

Posted by GitBox <gi...@apache.org>.
ggershinsky commented on PR #973:
URL: https://github.com/apache/parquet-mr/pull/973#issuecomment-1188622982

   sure. if no other input by the end of this week, I'll merge it then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on pull request #973: PARQUET-2155: Upgrade protobuf version to 3.17.3

Posted by GitBox <gi...@apache.org>.
shangxinli commented on PR #973:
URL: https://github.com/apache/parquet-mr/pull/973#issuecomment-1189167965

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] sunchao commented on pull request #973: PARQUET-2155: Upgrade protobuf version to 3.20.1

Posted by GitBox <gi...@apache.org>.
sunchao commented on PR #973:
URL: https://github.com/apache/parquet-mr/pull/973#issuecomment-1152458544

   To reduce the risk, we can also change 3.20.1 to 3.17.1 which seems to be the lowest version that has the aarch_64 artifact. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] sunchao commented on pull request #973: PARQUET-2155: Upgrade protobuf version to 3.17.3

Posted by GitBox <gi...@apache.org>.
sunchao commented on PR #973:
URL: https://github.com/apache/parquet-mr/pull/973#issuecomment-1183753880

   gently ping @shangxinli @ggershinsky 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] steveloughran commented on pull request #973: PARQUET-2155: Upgrade protobuf version to 3.17.3

Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #973:
URL: https://github.com/apache/parquet-mr/pull/973#issuecomment-1190501542

   now this is merged in, should the jira be closed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] steveloughran commented on pull request #973: PARQUET-2155: Upgrade protobuf version to 3.20.1

Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #973:
URL: https://github.com/apache/parquet-mr/pull/973#issuecomment-1152146993

   this is a different solution to mine, which just changed the protoc artifact. i think my one is lower risk, but this one can address other protobuf issues


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org